Draft
Conversation
sreya
force-pushed
the
heartbeat-batcher
branch
3 times, most recently
from
a3e7160 to
36ffd0e
Compare
Reduces agent connection heartbeat DB writes from ~667/s to ~2/s at 10k agents by batching UpdateWorkspaceAgentConnectionByID calls. Disconnect writes bypass the batcher for immediate visibility.
sreya
force-pushed
the
heartbeat-batcher
branch
from
36ffd0e to
44ea26c
Compare
Rename files: - batcher.go -> heartbeats.go - batcher_test.go -> heartbeats_internal_test.go - batcher_db_test.go -> heartbeats_test.go Prefix exported symbols with Heartbeat to avoid collisions with existing agentapi package exports.
Match the pattern used by BatchUpdateWorkspaceAgentMetadata: require ActionUpdate on ResourceWorkspace.All() rather than bypassing auth. Also fix unused-receiver lint warning in test.
Verify the batch query works for n > 1 agents in a single flush.
Use a unique later2 timestamp for agent2 to verify each agent's values are committed independently. Switch from WithinDuration to Equal for exact assertions.
Add an updated_at guard to the BatchUpdateWorkspaceAgentConnections SQL query so that a batch flush never overwrites a newer value that was written directly (or vice versa) when the channel-full fallback is triggered. Also switch the DB integration test to use dbtime.Now() for timestamps so they are always after the agent's creation updated_at.
Collaborator
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 88943169f9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Use NULLIF in the SQL SET clause to convert Go zero-value sentinels (epoch for timestamptz, nil UUID) back to NULL. Without this, an invalid sql.NullTime for disconnected_at would be written as the epoch (year 0001), corrupting connection metadata for agents that have never disconnected. Add test assertions verifying disconnected_at remains NULL when the update does not set it.
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduces agent connection heartbeat DB writes from ~667/s to ~2/s at 10k agents by batching UpdateWorkspaceAgentConnectionByID calls. Disconnect writes bypass the batcher for immediate visibility.