Repository navigation
feat(site): rich preview for the spawn_computer_use_agent tool - #23684
Conversation
8ebf2f0 to
1ff62f4
Compare
|
@hugodutka for a preview I don't like how big it is. I'd rather it was smaller and said like "Using the Computer" in shimmer text - that would be dope. Like a little 128px height card. With a clear "Click to view" that would open the side-panel or something. I'm also happy to fix this up afterwards. |
|
@kylecarbs I'd rather change this afterwards on Monday. I think Danielle is planning to do a major frontend refactor tomorrow, so it'd be more convenient for me to lock the logic in and change the look later. |
mafredri
left a comment
There was a problem hiding this comment.
Clean work overall. The DesktopPanelContext design is solid, the connectionOverride testing seam avoids fragile module mocks, and the aria-expanded fix is a nice accessibility improvement done without being asked. Storybook coverage across all VNC connection states is thorough.
1 P2, 5 P3s, 1 observation, and 6 nits across 11 inline comments.
Meruem: "Each hook instance creates its own RFB instance, WebSocket, reconnect timers, and ResizeObserver. Multiple wait_agent or message_agent calls referencing the same desktop subagent each get their own inline preview, each opening its own WebSocket. The worst case is N inline previews plus the sidebar panel: N+1 concurrent VNC connections to one desktop."
Hisoka: "The stories look correct at a glance and break on interaction. That's my favorite kind."
🤖 This review was automatically generated with Coder Agents.
1ff62f4 to
88e69a1
Compare
mafredri
left a comment
There was a problem hiding this comment.
Thanks for fixing the noVNC private internals issue. Reading canvas dimensions from the DOM is cleaner.
The SidebarTabView stories (F2 from round 1) still throw on tab click since onActiveTabChange is undefined at runtime. That's the one remaining item worth fixing before merge. The rest is acknowledged/deferred or nits.
🤖 This review was automatically generated with Coder Agents.
88e69a1 to
7d18cfe
Compare
mafredri
left a comment
There was a problem hiding this comment.
All findings addressed. The showDesktopPreviews prop is a clean solution to F3, letting historical messages show MonitorIcon without opening dead VNC connections. Stories fixed, dead code removed, nits resolved.
No new issues in the delta.
🤖 This review was automatically generated with Coder Agents.
Adds preview cards for the
spawn_computer_use_agenttool. Spawning that agent now renders a rich saying "Spawning computer use sub-agent". The "waiting for" tool now displays an inline desktop preview which can be clicked to reveal the desktop in the sidebar.Screen.Recording.2026-03-26.at.18.47.05.mov