Repository navigation
fix(coderd/x/chatd/mcpclient): use dedicated HTTP transport per MCP connection - #23494
Merged
Merged
Conversation
…onnection Each MCP client connection was implicitly using http.DefaultTransport. When httptest.Server.Close() runs during parallel tests, it calls CloseIdleConnections on http.DefaultTransport, breaking in-flight connections from other tests or goroutines within the same test. Clone the default transport for each connection so that idle connection cleanup is scoped to a single MCP server and cannot disrupt unrelated connections. Fixes coder/internal#1420
johnstcn
approved these changes
Mar 24, 2026
johnstcn
left a comment
Member
There was a problem hiding this comment.
I wonder if this should be a util function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
TestConnectAll_MultipleServersflakes with:Each MCP client connection implicitly uses
http.DefaultTransport. Whenhttptest.Server.Close()runs during parallel test cleanup, it callsCloseIdleConnectionsonhttp.DefaultTransport, breaking in-flight connections from other goroutines or parallel tests sharing that transport.Fix
Clone the default transport for each MCP connection via
http.DefaultTransport.(*http.Transport).Clone(), passed throughWithHTTPBasicClient(StreamableHTTP) andWithHTTPClient(SSE). This scopes idle connection cleanup to a single MCP server so it cannot disrupt unrelated connections.Fixes coder/internal#1420