Skip to content

Stop showing persistent vs ephemeral for resources - #2333

Merged
spikecurtis merged 3 commits into
mainfrom
spike/1937_drop_permanent_ephemeral
Jun 16, 2022
Merged

spikecurtis merged 3 commits into
mainfrom
spike/1937_drop_permanent_ephemeral

Conversation

@spikecurtis

Copy link
Copy Markdown
Collaborator

Fixes #1937

One thing that we might want to do is fix up the template creation job to only run the start transition, since we now only display those resources. However, I didn't do it in this PR because maybe we still want to keep it around to catch errors or other purposes...

Signed-off-by: Spike Curtis <spike@coder.com>
@spikecurtis
spikecurtis requested a review from a team June 14, 2022 23:14

@deansheather deansheather left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep the stop transition in the template import job to ensure that it successfully plans a stop job

@spikecurtis
spikecurtis enabled auto-merge (squash) June 14, 2022 23:22
@spikecurtis
spikecurtis merged commit 93b1425 into main Jun 16, 2022
@spikecurtis
spikecurtis deleted the spike/1937_drop_permanent_ephemeral branch June 16, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

coder show incorrectly shows permanent resources as ephemeral.

2 participants