fix(cored): fix flaky TestInterruptAutoPromotionIgnoresLaterUsageLimitIncrease#23147
Merged
ibetitsmike merged 1 commit intoMar 17, 2026
Merged
Conversation
…tIncrease Send "later queued" immediately after "queued" while the first message is still in chat_queued_messages. The existing backlog (len(existingQueued) > 0) guarantees queueing regardless of chat status, avoiding a race where the auto-promoted "queued" message finishes processing before the second SendMessage is called.
ibetitsmike
changed the title
ibetitsmike
changed the title
ibetitsmike
changed the title
ibetitsmike
changed the title
deansheather
approved these changes
Mar 17, 2026
ibetitsmike
deleted the
fix/flake-interrupt-autopromote-later-usage-limit
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes coder/internal#1406
Root cause
The second
SendMessage("later queued")was called after waiting for theinterruptedchannel. By that point, the auto-promoted "queued" message'sprocessChatcould complete (request #2 returns instantly viaOpenAIStreamingResponse), leaving the chat inWaitingstatus with an empty queue.shouldQueueUserMessage(Waiting)returnsfalseandlen(existingQueued) == 0, so the message was inserted directly instead of queued —Queued: false.Fix
Move
SendMessage("later queued")to immediately afterSendMessage("queued"), before waiting for the interrupt. At that point, "queued" is guaranteed to still be inchat_queued_messages(the auto-promotion requires multiple goroutine switches and DB transactions that cannot complete between two consecutive synchronous calls). Thelen(existingQueued) > 0condition reliably triggers queueing regardless of chat status.Passes 25/25 with
-count=25.