Skip to content

feat(site): move Settings and Analytics from dialogs to sidebar sub-navigation#23126

Merged
DanielleMaywood merged 6 commits intomainfrom
daniellemaywood/sidebar-settings-analytics
Mar 17, 2026
Merged

feat(site): move Settings and Analytics from dialogs to sidebar sub-navigation#23126
DanielleMaywood merged 6 commits intomainfrom
daniellemaywood/sidebar-settings-analytics

Conversation

@DanielleMaywood
Copy link
Copy Markdown
Contributor

@DanielleMaywood DanielleMaywood commented Mar 16, 2026

Move away from Dialog for analytics/settings/etc

image image image

@DanielleMaywood DanielleMaywood force-pushed the daniellemaywood/sidebar-settings-analytics branch 17 times, most recently from f952d88 to e16a796 Compare March 16, 2026 17:30
@DanielleMaywood DanielleMaywood marked this pull request as ready for review March 16, 2026 17:35
@kylecarbs
Copy link
Copy Markdown
Member

@DanielleMaywood we should center the content with the same max-width as chats (same with the padding). Then this will feel similar to the chats view, which is cool.

@DanielleMaywood
Copy link
Copy Markdown
Contributor Author

@DanielleMaywood we should center the content with the same max-width as chats (same with the padding). Then this will feel similar to the chats view, which is cool.

Good call, have done that.

@DanielleMaywood DanielleMaywood force-pushed the daniellemaywood/sidebar-settings-analytics branch from 87e2b3f to 6e3b63a Compare March 17, 2026 09:03
@coder-tasks
Copy link
Copy Markdown
Contributor

coder-tasks bot commented Mar 17, 2026

Documentation Check

Updates Needed

  • docs/ai-coder/agents/models.md - Steps in Add a provider (line 32) say Click **Admin** in the top bar to open the configuration dialog and in Add a model (line 67) say Open the **Admin** dialog. These now navigate to a sidebar sub-navigation panel instead of opening a dialog. The step descriptions and the alt text on screenshots (lines 40, 78) that reference "the admin dialog" all need updating to match the new UX.

Automated review via Coder Tasks

@DanielleMaywood DanielleMaywood force-pushed the daniellemaywood/sidebar-settings-analytics branch 3 times, most recently from 71cc8f5 to f15ba11 Compare March 17, 2026 13:16
…avigation

Replace the cramped dialog-based Settings and Analytics views with
full-page content rendered inline. The sidebar now has dedicated
Settings and Analytics buttons that, when clicked, animate a sliding
panel transition to reveal sub-navigation items (Behavior, Providers,
Models, Usage for Settings; a simple back header for Analytics).

Key changes:

- AgentsSidebar: two absolutely-positioned panels with CSS
  translate transitions. Panel 1 is the chat list with new
  full-width Settings/Analytics buttons above the user section.
  Panel 2 is the sub-navigation with a back arrow header and
  section items. Off-screen panels get aria-hidden and inert.

- AgentsPageView: sidebar view state (chats | settings | analytics)
  drives which content the main area renders. Removes
  ConfigureAgentsDialog and UserAnalyticsDialog usage.

- SettingsPageContent: extracts the settings content from
  ConfigureAgentsDialog into a full-page component. Exports
  getSettingsSectionOptions() for the sidebar nav items.

- AnalyticsPageContent: extracts the analytics content from
  UserAnalyticsDialog into a full-page component.
When entering settings, store the origin path in location.state.
Sub-section clicks (Behavior/Providers/Models/Usage) use replace: true
and forward the state so it persists across tab switches. The back
arrow reads state.from and falls back to /agents when there is no
prior location (e.g. deep-linked to a settings URL).
Use max-w-3xl and p-4 padding to match the chat views
(AgentCreateForm and ConversationTimeline) so settings and
analytics feel visually consistent with the rest of the page.
Navigation items (Settings, Analytics, back arrow, New Agent, and
all settings sub-section items) now render as <Link> elements
instead of <button> with onClick+navigate(). This means they are
proper <a> tags, so right-click → open in new tab, cmd/ctrl+click,
and screen reader link announcements all work correctly.

SettingsNavItem accepts either 'to' (renders <Link>) or 'onClick'
(renders <button>) via a discriminated union. The link variant also
accepts an optional onClick for side-effects (e.g. New Agent clears
a localStorage draft before navigating).
@DanielleMaywood DanielleMaywood force-pushed the daniellemaywood/sidebar-settings-analytics branch 3 times, most recently from 1ebad51 to 54576e2 Compare March 17, 2026 14:10
Settings and Analytics are now icon-only buttons in the top bar next
to Filter and Collapse, using the same Button variant='subtle'
size='icon' styling (h-7 w-7, text-content-secondary with
hover/active highlight). They remain accessible links via
Button asChild wrapping Link elements.

Removes the full-width text nav items that were below New Agent.
@DanielleMaywood DanielleMaywood force-pushed the daniellemaywood/sidebar-settings-analytics branch from 54576e2 to b0d4be4 Compare March 17, 2026 14:25
@DanielleMaywood DanielleMaywood merged commit 635c5d5 into main Mar 17, 2026
23 checks passed
@DanielleMaywood DanielleMaywood deleted the daniellemaywood/sidebar-settings-analytics branch March 17, 2026 14:48
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants