feat(site): move Settings and Analytics from dialogs to sidebar sub-navigation#23126
Merged
DanielleMaywood merged 6 commits intomainfrom Mar 17, 2026
Merged
Conversation
f952d88 to
e16a796
Compare
Member
|
@DanielleMaywood we should center the content with the same max-width as chats (same with the padding). Then this will feel similar to the chats view, which is cool. |
Contributor
Author
Good call, have done that. |
87e2b3f to
6e3b63a
Compare
Contributor
Documentation CheckUpdates Needed
Automated review via Coder Tasks |
71cc8f5 to
f15ba11
Compare
…avigation Replace the cramped dialog-based Settings and Analytics views with full-page content rendered inline. The sidebar now has dedicated Settings and Analytics buttons that, when clicked, animate a sliding panel transition to reveal sub-navigation items (Behavior, Providers, Models, Usage for Settings; a simple back header for Analytics). Key changes: - AgentsSidebar: two absolutely-positioned panels with CSS translate transitions. Panel 1 is the chat list with new full-width Settings/Analytics buttons above the user section. Panel 2 is the sub-navigation with a back arrow header and section items. Off-screen panels get aria-hidden and inert. - AgentsPageView: sidebar view state (chats | settings | analytics) drives which content the main area renders. Removes ConfigureAgentsDialog and UserAnalyticsDialog usage. - SettingsPageContent: extracts the settings content from ConfigureAgentsDialog into a full-page component. Exports getSettingsSectionOptions() for the sidebar nav items. - AnalyticsPageContent: extracts the analytics content from UserAnalyticsDialog into a full-page component.
When entering settings, store the origin path in location.state. Sub-section clicks (Behavior/Providers/Models/Usage) use replace: true and forward the state so it persists across tab switches. The back arrow reads state.from and falls back to /agents when there is no prior location (e.g. deep-linked to a settings URL).
Use max-w-3xl and p-4 padding to match the chat views (AgentCreateForm and ConversationTimeline) so settings and analytics feel visually consistent with the rest of the page.
Navigation items (Settings, Analytics, back arrow, New Agent, and all settings sub-section items) now render as <Link> elements instead of <button> with onClick+navigate(). This means they are proper <a> tags, so right-click → open in new tab, cmd/ctrl+click, and screen reader link announcements all work correctly. SettingsNavItem accepts either 'to' (renders <Link>) or 'onClick' (renders <button>) via a discriminated union. The link variant also accepts an optional onClick for side-effects (e.g. New Agent clears a localStorage draft before navigating).
1ebad51 to
54576e2
Compare
Settings and Analytics are now icon-only buttons in the top bar next to Filter and Collapse, using the same Button variant='subtle' size='icon' styling (h-7 w-7, text-content-secondary with hover/active highlight). They remain accessible links via Button asChild wrapping Link elements. Removes the full-width text nav items that were below New Agent.
54576e2 to
b0d4be4
Compare
kylecarbs
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move away from Dialog for analytics/settings/etc