Skip to content

feat(site): searchable workspace selector in agent chat input#22656

Merged
DanielleMaywood merged 1 commit intomainfrom
feat/searchable-workspace-selector
Mar 5, 2026
Merged

feat(site): searchable workspace selector in agent chat input#22656
DanielleMaywood merged 1 commit intomainfrom
feat/searchable-workspace-selector

Conversation

@DanielleMaywood
Copy link
Copy Markdown
Contributor

Replaces the radix <Select> workspace dropdown in the agent chat input with the existing <Combobox> component (cmdk-powered), adding a search field to filter workspaces by owner or name.

Changes

  • AgentsPage.tsx — Swap Select for Combobox with ComboboxInput for search. Each workspace item uses keywords={[owner_name, name]} for filtering.
  • AgentsPage.stories.tsx — Fix WithWorkspaces role assertion (listboxdialog). Add SearchWorkspaces and SelectWorkspaceViaSearch stories covering filter and selection flows.

@DanielleMaywood DanielleMaywood force-pushed the feat/searchable-workspace-selector branch 2 times, most recently from 2d50bf1 to 5c8b339 Compare March 5, 2026 11:19
Swap the radix Select for the existing Combobox (cmdk-powered) in the
agent chat input workspace dropdown. This adds a search field so users
can filter workspaces by owner or name.

- Replace Select imports with Combobox in AgentsPage.tsx
- Add keywords prop on each workspace item for owner/name matching
- Fix WithWorkspaces story role assertion (listbox -> dialog)
- Add SearchWorkspaces and SelectWorkspaceViaSearch stories
@DanielleMaywood DanielleMaywood force-pushed the feat/searchable-workspace-selector branch from 5c8b339 to ff1b074 Compare March 5, 2026 11:23
@DanielleMaywood DanielleMaywood marked this pull request as ready for review March 5, 2026 11:30
Copy link
Copy Markdown
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as you've made sure the sizing is approx correct for text in there I'm good with it

@DanielleMaywood DanielleMaywood merged commit b0e1040 into main Mar 5, 2026
26 of 28 checks passed
@DanielleMaywood DanielleMaywood deleted the feat/searchable-workspace-selector branch March 5, 2026 11:38
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants