Repository navigation
refactor(site): replace DiffRightPanel with generic tabbed RightPanel - #22633
Merged
Merged
Conversation
Replace the single-purpose DiffRightPanel with a generic RightPanel component that supports tabs, drag-resize, drag-to-snap (expanded, closed), and drag-to-collapse-sidebar. Key changes: - New RightPanel.tsx: generic tabbed panel with drag handle, snap thresholds for expand/close, persisted width, and live sidebar collapse when dragging to the left viewport edge - Parent provides tab content via tabContent record; panel owns tab definitions and active tab state internally - Drag state syncs live to parent via onVisualExpandedChange so sibling content (chat section) hides/shows during drag, not just on pointer-up - Removed DiffRightPanel.tsx - Updated AgentDetail.tsx to use RightPanel with visualExpanded derived from both committed state and drag override - Removed border/background from FilesChangedPanel (now handled by RightPanel wrapper)
kylecarbs
force-pushed
the
kylecarbs/right-panel
branch
from
March 5, 2026 00:29
4b5936d to
565a975
Compare
mattvollmer
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the single-purpose DiffRightPanel with a generic RightPanel component that supports tabs, drag-resize, drag-to-snap, and drag-to-collapse-sidebar.
Changes
RightPanel.tsx: generic tabbed panel with:onVisualExpandedChangecallback so parent syncs sibling visibility during drag (not just on pointer-up)DiffRightPanel.tsxAgentDetail.tsx: usesRightPanelwithtabContentrecord, tracksdragVisualExpandedfor live chat section hidingFilesChangedPanel.tsx: removed border/background (now handled by RightPanel wrapper)Drag behavior