Repository navigation
Conversation
Switch from Yarn Classic (1.22) to Yarn Berry (3.1.1) in order to speed up install and builds.
Codecov Report
@@ Coverage Diff @@
## main #224 +/- ##
==========================================
+ Coverage 68.31% 68.44% +0.13%
==========================================
Files 111 111
Lines 6003 6003
Branches 67 67
==========================================
+ Hits 4101 4109 +8
+ Misses 1512 1507 -5
+ Partials 390 387 -3
Continue to review full report at Codecov.
|
|
How much does this improve build times? |
kylecarbs
left a comment
There was a problem hiding this comment.
Seems fine to me, but I'd like @bryphe-coder to take a look!
| /.yarn/* | ||
| !/.yarn/patches | ||
| !/.yarn/plugins | ||
| !/.yarn/releases | ||
| !/.yarn/sdks |
There was a problem hiding this comment.
Will this affect the directories we need to cache in our workflow? ie
coder/.github/workflows/coder.yaml
Line 60 in c44d036
There was a problem hiding this comment.
yea it would. I think it'd be much faster with Plug 'n Play mode, but I couldn't get that working
| @@ -1,5 +1,6 @@ | |||
| { | |||
| "name": "coder-v2", | |||
| "packageManager": "yarn@3.1.1", | |||
There was a problem hiding this comment.
Thanks for investigating this!
|
No-op vs the With yarn 3 + pnp: |
|
Running yarn 3: yarn 1: The fresh-install seems comparable but yarn 3 is still surprisingly a little slower. With PnP enabled + yarn 3: |
|
@jawnsy - do you think the benefits of yarn 3 outweigh the additional time for fresh install / no-op install? I'm more concerned about the no-op install because that will be hit in the development flow. From my testing locally - it seems like yarn 3 is (surprisingly) slower in both those cases 😦 Wondering if we should hold off on this until we can investigate the PnP issue and get the perf benefit? |
There was a problem hiding this comment.
Just curious on your thoughts re: perf @jawnsy - did you see different results when you tested?
|
@bryphe-coder and I are going to check this out on Monday for testing Monday to see if we can get PnP working, otherwise I'll just close this :) |
|
After some investigation, it doesn't seem to be a material performance improvement for us, so it's not worth doing at this time |
#30873) ## Summary An axe sweep of every page on https://coder.com/beta-docs (coder/docs-engine#224) found two content-side problems. Nine screenshots have alt text identical to the italic caption right after them, so screen readers read the same words twice (axe `image-redundant-alt`). Four hand-written tables have an empty top-left header cell, which leaves their row-label column without a name (axe `empty-table-header`). This fixes both. These are content fixes on `main` only; earlier release lines keep the old text. ## Findings | Rule | Pages | Cause | Fixed where | | --- | --- | --- | --- | | image-redundant-alt | 4 | Alt text repeats the caption | This PR | | empty-table-header | 4 hand-written | Empty corner header cell | This PR | | empty-table-header | 105 CLI reference pages, `audit-logs.md` | Generated tables with empty headers | Not here: needs a generator change | | empty-table-header | `admin/networking/port-forwarding.md` | Spanning corner cells in a raw HTML matrix | Not here: needs a rework of that table | | heading-order | `remote-desktops.md` | `<div class="tab">` typo | Separate PR | | link-name, scrollable-region-focusable, aria-valid-attr-value, label | many | Engine | coder/docs-engine #220, #217, #224 | ## Fix Each of the nine screenshots gets alt text that describes what it shows (for example, "Preset dropdown with Ruby Development added between Full Stack and Web Development"), and keeps its caption. The corner cells become "Permission" (Groups and roles), "Component" (air-gapped comparison), "Scenario" (scale-testing workloads) and "Input" (workspace tags). Tables were re-padded with `markdown-table-formatter`. ## QA 1. Open each production page below. Expected: the screenshots and tables look the same as before, except the four tables now show a word in their top-left header cell. 2. In Chrome DevTools (Elements) or Firefox's Inspector, select a screenshot on the Add a language page. Expected: its `alt` differs from the italic caption under it. ## Pages to compare | What to check | Production | Preview | | --- | --- | --- | | Screenshot alt text vs caption | https://coder.com/beta-docs/@main/get-started/customize-your-template/add-a-language/ | This PR's GitHub preview: https://github.com/coder/coder/blob/vigilante/docs-a11y-fixes/docs/get-started/customize-your-template/add-a-language.md | | Roles table corner cell | https://coder.com/beta-docs/@main/admin/users/groups-roles/ | https://github.com/coder/coder/blob/vigilante/docs-a11y-fixes/docs/admin/users/groups-roles.md | | Scale-testing table corner cell | https://coder.com/beta-docs/@main/install/validate/scale-testing/ | https://github.com/coder/coder/blob/vigilante/docs-a11y-fixes/docs/install/validate/scale-testing.md | ## Testing `markdownlint-cli2` and `markdown-table-formatter` over the eight changed files: 0 errors. Re-running the sweep after merge should drop `image-redundant-alt` and the four tables' `empty-table-header` findings from `@main`. ## Upstream No: these are Coder content fixes, not Fumadocs bugs. Linear: [DOCS-1303](https://linear.app/coder/issue/DOCS-1303) --- 🤖 Built with AI assistance.
Switch from Yarn Classic (1.22) to Yarn Berry (3.1.1) in order
to speed up install and builds.