Repository navigation
fix: Accept CODER_CACHE_DIRECTORY with CACHE_DIRECTORY fallback - #2236
Merged
Merged
Conversation
kylecarbs
approved these changes
Jun 10, 2022
kylecarbs
left a comment
Member
There was a problem hiding this comment.
Seems reasonable. It wasn't obvious this was for compatibility with systems based off the naming, but I'm happy it's more obvious now!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I reported #2199, I didn't realize the naming was due to systemd compat.
I still think it'd be worthwile to be able to explicitly specify a directory for coder caches, as such this PR changes the behavior to use
CODER_CACHE_DIRECTORYprimarily, andCACHE_DIRECTORYas a fallback.Fixes #2199