Skip to content

fix: Accept CODER_CACHE_DIRECTORY with CACHE_DIRECTORY fallback - #2236

Merged
mafredri merged 3 commits into
mainfrom
mafredri/fix-cache-dir-env
Jun 10, 2022
Merged

mafredri merged 3 commits into
mainfrom
mafredri/fix-cache-dir-env

Conversation

@mafredri

Copy link
Copy Markdown
Member

When I reported #2199, I didn't realize the naming was due to systemd compat.

I still think it'd be worthwile to be able to explicitly specify a directory for coder caches, as such this PR changes the behavior to use CODER_CACHE_DIRECTORY primarily, and CACHE_DIRECTORY as a fallback.

Fixes #2199

@mafredri
mafredri requested review from a team and kylecarbs June 10, 2022 12:19
@mafredri mafredri self-assigned this Jun 10, 2022

@kylecarbs kylecarbs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. It wasn't obvious this was for compatibility with systems based off the naming, but I'm happy it's more obvious now!

@mafredri
mafredri merged commit 0260e39 into main Jun 10, 2022
@mafredri
mafredri deleted the mafredri/fix-cache-dir-env branch June 10, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cache directory env variable for coder server is missing CODER_ prefix

2 participants