Skip to content

chore: remove extra stop_modules from provisionerd proto#21706

Merged
Emyrk merged 3 commits intomainfrom
stevenmasley/remove_stop_modules
Jan 28, 2026
Merged

chore: remove extra stop_modules from provisionerd proto#21706
Emyrk merged 3 commits intomainfrom
stevenmasley/remove_stop_modules

Conversation

@Emyrk
Copy link
Copy Markdown
Member

@Emyrk Emyrk commented Jan 27, 2026 •
edited
Loading

Was a duplicate of start_modules

Closes #21206

@Emyrk Emyrk marked this pull request as ready for review January 27, 2026 18:26
@coder-tasks
Copy link
Copy Markdown
Contributor

coder-tasks bot commented Jan 27, 2026

Documentation Check

No Changes Needed

This PR removes a duplicate field (stop_modules) from the internal provisionerd gRPC protocol and bumps the API version from 1.14 to 1.15.

Reasoning:

  • The provisionerd API is an internal protocol between the Coder control plane and provisioner daemons
  • Users interact with provisioners through CLI commands, Helm charts, and template creation - none of which are affected by this internal protocol change
  • Existing documentation in docs/admin/provisioners/ correctly focuses on deployment, authentication, and tagging rather than internal API details
  • The API version bump is handled internally and doesn't require user documentation

Automated review via Coder Tasks

johnstcn
johnstcn reviewed Jan 27, 2026
View reviewed changes
cli/testdata/coder_provisioner_list_--output_json.golden
"name": "test-daemon",
"version": "v0.0.0-devel",
"api_version": "1.14",
"api_version": "1.15",
Copy link
Copy Markdown
Member

@johnstcn johnstcn Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heads-up: potential conflict with #21602

Copy link
Copy Markdown
Member Author

@Emyrk Emyrk Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good callout

coderd/provisionerdserver/provisionerdserver_test.go
Version: "2.0.0",
Source: "github.com/example2/example",
Transition: database.WorkspaceTransitionStop,
Transition: database.WorkspaceTransitionStart,
Copy link
Copy Markdown
Member

@johnstcn johnstcn Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is expected because all modules only come from start now?

Copy link
Copy Markdown
Member Author

@Emyrk Emyrk Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. Honestly the transition is not even useful anymore. The start being referred to comes from InitComplete now. Not even the plan. So it comes from template import.

WorkspaceTransitionStart is hard coded here:

coder/coderd/provisionerdserver/provisionerdserver.go

Lines 1653 to 1668 in f0e918c

for transition, modules := range map[database.WorkspaceTransition][]*sdkproto.Module{
database.WorkspaceTransitionStart: jobType.TemplateImport.StartModules,
} {
for _, module := range modules {
s.Logger.Info(ctx, "inserting template import job module",
slog.F("job_id", job.ID.String()),
slog.F("module_source", module.Source),
slog.F("module_version", module.Version),
slog.F("module_key", module.Key),
slog.F("transition", transition))
if err := InsertWorkspaceModule(ctx, db, jobID, transition, module, telemetrySnapshot); err != nil {
return xerrors.Errorf("insert module: %w", err)
}
}
}

It will never be another transition

@Emyrk Emyrk merged commit e13f2a9 into main Jan 28, 2026
29 checks passed
@Emyrk Emyrk deleted the stevenmasley/remove_stop_modules branch January 28, 2026 15:25
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@johnstcn johnstcn johnstcn approved these changes

@spikecurtis spikecurtis Awaiting requested review from spikecurtis spikecurtis is a code owner

Assignees

@Emyrk Emyrk

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove StopModules from returned template import metadata

2 participants

@Emyrk @johnstcn