feat(helm): add priorityClassName support#20678
Merged
rowansmithau merged 4 commits intocoder:mainfrom Nov 24, 2025
Merged
Conversation
cdr-bot
bot
added
the
community
|
All contributors have signed the CLA ✍️ ✅ |
leo-wr-ps
force-pushed
the
feat-helm_20676-priorityClassName
branch
from
f2d2c1d to
0afe8bb
Compare
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
cdrci2
added a commit
to coder/cla
that referenced
this pull request
Nov 6, 2025
Contributor
Author
|
recheck |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for specifying a priorityClassName for Coder pods in the Helm chart deployment, allowing users to control pod scheduling priority in Kubernetes clusters.
- Adds
coder.priorityClassNameconfiguration option to the Helm values - Implements conditional rendering of
priorityClassNamein the deployment template - Includes comprehensive test coverage with golden file tests for both default and coder namespaces
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
helm/libcoder/templates/_coder.yaml |
Adds conditional template logic to render priorityClassName field in pod spec |
helm/coder/values.yaml |
Defines new priorityClassName configuration option with documentation and empty string default |
helm/coder/tests/testdata/priority_class_name.yaml |
Provides test input values with priorityClassName: high-priority |
helm/coder/tests/testdata/priority_class_name.golden |
Golden file showing expected rendered output for default namespace |
helm/coder/tests/testdata/priority_class_name_coder.golden |
Golden file showing expected rendered output for coder namespace |
helm/coder/tests/chart_test.go |
Adds test case entry for priority_class_name tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rowansmithau
approved these changes
Nov 23, 2025
Contributor
Author
|
@rowansmithau thanks for approving. Anything else needed on my side to get this merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add priorityClassName support to Coder Helm chart
Add coder.priorityClassName configuration to the Helm chart that allows setting the pod's priorityClassName in the deployment
Usage:
See: #20676