Skip to content

feat: Add links to the resource card for workspace applications - #2067

Merged
kylecarbs merged 3 commits into
mainfrom
appui
Jun 6, 2022
Merged

kylecarbs merged 3 commits into
mainfrom
appui

Conversation

@kylecarbs

@kylecarbs kylecarbs commented Jun 6, 2022 •

Copy link
Copy Markdown
Member

Fixes #1907 and #805.

I'll make this pretty in another PR!

image
This error screen is displayed when an application isn't reachable.

kylecarbs added 2 commits June 5, 2022 18:02
This was broken when improving the build times. The typechecker
unfortunately missed it!
Fixes #1907 and #805.

I'll make this pretty in another PR!
@kylecarbs
kylecarbs requested a review from a team as a code owner June 6, 2022 01:57
@kylecarbs kylecarbs self-assigned this Jun 6, 2022
userName={workspace.owner_name}
workspaceName={workspace.name}
/>
))}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would wrap these insides of a Stack to add some spacing between the items inside of this column. I would also add a default icon or a left margin if it does not have one to be aligned with the terminal to avoid the situation below:

Screen Shot 2022-06-06 at 10 39 41

@BrunoQuaresma BrunoQuaresma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me, just a minor observation related to the design.

@kylecarbs
kylecarbs merged commit ab8235f into main Jun 6, 2022
@kylecarbs
kylecarbs deleted the appui branch June 6, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add error metadata to index.html to forward backend errors

2 participants