Skip to content

feat: Authenticate Digital Ocean via environment variable - #2051

Merged
spikecurtis merged 3 commits into
mainfrom
spike/1967_authenticated_do
Jun 6, 2022
Merged

spikecurtis merged 3 commits into
mainfrom
spike/1967_authenticated_do

Conversation

@spikecurtis

Copy link
Copy Markdown
Collaborator

Second PR addressing #1967

Still need K8s to call it done.

Signed-off-by: Spike Curtis <spike@coder.com>
Signed-off-by: Spike Curtis <spike@coder.com>
Signed-off-by: Spike Curtis <spike@coder.com>
@spikecurtis
spikecurtis requested a review from bpmct June 3, 2022 21:31
@spikecurtis
spikecurtis enabled auto-merge (squash) June 3, 2022 23:40
@ammario

ammario commented Jun 4, 2022

Copy link
Copy Markdown
Member

Cleanly written 👍

@bpmct bpmct left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Noticed a bit more than DigitalOcean made it into this PR. Might want to edit the title before merging

Comment on lines +15 to +16
This template assumes that coderd is run in an environment that is authenticated
with Google Cloud. For example, run `gcloud auth application-default login` to import

@bpmct bpmct Jun 6, 2022 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think calling it coderd is unclear in this case. This was the name for the Coder binary in Coder Classic, but we don't refer to it as coderd in the user-facing product UI or documentation. I'd suggest calling it the "Coder host"

I did notice the code refers to it as "coderd"

Would like your thoughts though. We can merge and reconsider later.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a consistent set of terms for various components of the project / solution, and for v1 stuff moving forward (are we calling this "Coder Classic"!?). Perhaps you and I can collaborate on a RFC to this effect and get some more input.

It's really a drag to have different internal and external names down at the component level. Engineers will naturally screw up terminology in documents, customer interactions, etc. So, there has to be a really strong case for naming these things differently.

@spikecurtis
spikecurtis merged commit 3f3ecbf into main Jun 6, 2022
@spikecurtis
spikecurtis deleted the spike/1967_authenticated_do branch June 6, 2022 12:05
@bpmct bpmct mentioned this pull request Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants