Repository navigation
Conversation
This was referenced Oct 23, 2025
This was referenced Oct 23, 2025
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ThomasK33
force-pushed
the
thomask33/10-23-enforce_api_key_time_checks
branch
from
October 24, 2025 10:23
18f8a4e to
9efa897
Compare
ThomasK33
changed the base branch from
thomask33/09-25-resource_scoped_api_keys_in_codersdk
to
graphite-base/20444
October 24, 2025 11:33
ThomasK33
force-pushed
the
thomask33/10-23-enforce_api_key_time_checks
branch
from
October 24, 2025 11:35
9efa897 to
c853e86
Compare
ThomasK33
force-pushed
the
graphite-base/20444
branch
from
October 24, 2025 11:35
42451c1 to
f684831
Compare
ThomasK33
force-pushed
the
thomask33/10-23-enforce_api_key_time_checks
branch
6 times, most recently
from
October 24, 2025 16:45
ed96ae7 to
653cb07
Compare
ThomasK33
marked this pull request as ready for review
October 24, 2025 16:46
ThomasK33
force-pushed
the
thomask33/10-23-enforce_api_key_time_checks
branch
from
October 26, 2025 09:32
653cb07 to
3090b36
Compare
ThomasK33
force-pushed
the
thomask33/10-23-enforce_api_key_time_checks
branch
6 times, most recently
from
October 27, 2025 18:15
47af1e4 to
965240f
Compare
ThomasK33
force-pushed
the
thomask33/10-23-enforce_api_key_time_checks
branch
from
October 28, 2025 08:08
965240f to
a8fd73e
Compare
Add checks to require positive API key lifetime and non-retro expiry. Backfill bad rows before constraint to crash fast on regressions. Update test API keys to assert sensible CreatedAt timestamps.
ThomasK33
force-pushed
the
thomask33/10-23-enforce_api_key_time_checks
branch
from
October 28, 2025 13:48
a8fd73e to
cfe60ff
Compare
github-actions
Bot
deleted the
thomask33/10-23-enforce_api_key_time_checks
branch
April 29, 2026 00:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Add Database Constraints for API Key Validity
This PR adds database-level constraints to ensure API keys have valid expiration times and lifetimes:
api_keys_expires_at_after_createdconstraint to ensure expiration dates are always at or after creation datesapi_keys_lifetime_seconds_positiveconstraint to enforce positive lifetime valuesThe migration includes defensive updates to fix any existing data that would violate these constraints:
lifetime_secondsto 86400 (24 hours)expires_atvalues that are beforecreated_atto match the creation dateTests have been updated to ensure proper creation dates are set when testing expired API keys.