Skip to content

chore(coderd): introduce TaskAppID and deprecate AITaskSidebarAppID - #20336

Merged
DanielleMaywood merged 2 commits into
mainfrom
danielle/tasks/deprecate-ai-task-sidebar-app-id-field
Oct 24, 2025
Merged

DanielleMaywood merged 2 commits into
mainfrom
danielle/tasks/deprecate-ai-task-sidebar-app-id-field

Conversation

@DanielleMaywood

Copy link
Copy Markdown
Collaborator

As we're moving away from the SidebarAppID nomenclature, this PR introduces a new TaskAppID field to codersdk.WorkspaceBuild and deprecates the AITaskSidebarAppID field. They both contain the same value.

@DanielleMaywood
DanielleMaywood force-pushed the danielle/tasks/deprecate-ai-task-sidebar-app-id-field branch 4 times, most recently from 37589a9 to 0b96862 Compare October 21, 2025 11:27
As we're moving away from the SidebarAppID nomenclature, this PR
introduces a new `TaskAppID` field to `codersdk.WorkspaceBuild` and
deprecates the `AITaskSidebarAppID` field. They both contain the same
value.
@DanielleMaywood
DanielleMaywood force-pushed the danielle/tasks/deprecate-ai-task-sidebar-app-id-field branch from 0b96862 to b62e70b Compare October 21, 2025 11:35
@DanielleMaywood
DanielleMaywood marked this pull request as ready for review October 21, 2025 13:55
@DanielleMaywood
DanielleMaywood requested review from johnstcn and mafredri and removed request for aslilac and buenos-nachos October 21, 2025 13:55
@johnstcn

Copy link
Copy Markdown
Member

Can this wait until @mafredri 's stack goes in?

@DanielleMaywood

Copy link
Copy Markdown
Collaborator Author

@johnstcn Yep

@aslilac aslilac left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

frontend changes are all small and obvious enough :)

@DanielleMaywood
DanielleMaywood requested review from mafredri and removed request for mafredri October 24, 2025 09:12
Comment thread coderd/aitasks.go
if appURL == "" {
return httperror.NewResponseError(http.StatusInternalServerError, codersdk.Response{
Message: "Task sidebar app URL is not configured.",
Message: "Task app URL is not configured.",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be enforced provider-side? 🤔 It's unfortunate to let it be a runtime error that basically turns the task defunct 😅.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if you can do cross-resource validation in Terraform, and you define the url in the workspace_app resource :(

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then validation on provisioner side would perhaps be an option.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense to me

@DanielleMaywood
DanielleMaywood merged commit e60112e into main Oct 24, 2025
3 checks passed
@DanielleMaywood
DanielleMaywood deleted the danielle/tasks/deprecate-ai-task-sidebar-app-id-field branch October 24, 2025 09:57
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants