Skip to content

refactor: migrate TermsOfServiceLink from MUI to shadcn/ui#20260

Merged
jaaydenh merged 3 commits into
mainfrom
jaaydenh/refactor-terms-of-service
Oct 15, 2025
Merged

refactor: migrate TermsOfServiceLink from MUI to shadcn/ui#20260
jaaydenh merged 3 commits into
mainfrom
jaaydenh/refactor-terms-of-service

Conversation

@jaaydenh

@jaaydenh jaaydenh commented Oct 12, 2025

Copy link
Copy Markdown
Contributor

Summary

Migrate the TermsOfServiceLink component from MUI to shadcn/ui

Changes

  • Replaced @mui/material/Link with the custom Link component from components/Link/Link (shadcn/ui)
  • Migrated Emotion css prop to Tailwind utility classes
  • Preserved external link icon functionality (automatically provided by shadcn Link component)

🤖 Generated with Claude Code

Replace MUI Link with custom Link component from shadcn/ui and migrate
Emotion CSS to Tailwind utility classes. This is part of the ongoing
effort to standardize on shadcn/ui components and Tailwind CSS.

Changes:
- Replace @mui/material/Link with components/Link/Link
- Remove Emotion css prop in favor of Tailwind classes
- Maintain visual consistency with pt-3, text-base, font-medium
- Keep external link icon from shadcn Link component
- No functional changes to component behavior

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Comment thread site/src/pages/LoginPage/TermsOfServiceLink.tsx Outdated
rel="noreferrer"
>
Terms of Service&nbsp;
<SquareArrowOutUpRightIcon className="size-icon-xs" />

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why get rid of the arrow? it's to indicate it'll open in a new tab

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The component already has SquareArrowOutUpRightIcon inside it

@aslilac aslilac left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, I didn't realize the icon would come from the new component

@jaaydenh jaaydenh merged commit 3699ff6 into main Oct 15, 2025
26 checks passed
@jaaydenh jaaydenh deleted the jaaydenh/refactor-terms-of-service branch October 15, 2025 11:16
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants