Repository navigation
feat: add allow list to API keys - #19972
Merged
ThomasK33 merged 1 commit intoOct 24, 2025
Merged
Conversation
This was referenced Sep 25, 2025
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ThomasK33
force-pushed
the
thomask33/09-25-resource_scoped_api_keys_in_codersdk
branch
from
September 25, 2025 21:20
05cdebd to
5442fcd
Compare
ThomasK33
force-pushed
the
thomask33/09-25-feat_add_allow_list_field_api_keys
branch
from
September 26, 2025 07:45
1fea0d8 to
8013625
Compare
ThomasK33
force-pushed
the
thomask33/09-25-resource_scoped_api_keys_in_codersdk
branch
2 times, most recently
from
September 26, 2025 08:25
da32dec to
f2fbea4
Compare
ThomasK33
force-pushed
the
thomask33/09-25-feat_add_allow_list_field_api_keys
branch
from
September 26, 2025 08:25
8013625 to
4382587
Compare
ThomasK33
force-pushed
the
thomask33/09-25-resource_scoped_api_keys_in_codersdk
branch
from
September 26, 2025 09:31
f2fbea4 to
847f52e
Compare
ThomasK33
force-pushed
the
thomask33/09-25-feat_add_allow_list_field_api_keys
branch
from
September 26, 2025 10:16
4382587 to
fb2440e
Compare
ThomasK33
force-pushed
the
thomask33/09-25-resource_scoped_api_keys_in_codersdk
branch
from
September 26, 2025 10:17
847f52e to
1361b86
Compare
ThomasK33
force-pushed
the
thomask33/09-25-feat_add_allow_list_field_api_keys
branch
from
September 26, 2025 10:20
fb2440e to
ce693c0
Compare
ThomasK33
force-pushed
the
thomask33/09-25-resource_scoped_api_keys_in_codersdk
branch
from
September 26, 2025 10:20
1361b86 to
581bc52
Compare
ThomasK33
marked this pull request as ready for review
September 26, 2025 11:24
ThomasK33
force-pushed
the
thomask33/09-25-resource_scoped_api_keys_in_codersdk
branch
from
September 26, 2025 12:24
581bc52 to
6d17ef1
Compare
ThomasK33
force-pushed
the
thomask33/09-25-feat_add_allow_list_field_api_keys
branch
from
September 26, 2025 12:24
ce693c0 to
f1a4e56
Compare
ThomasK33
force-pushed
the
thomask33/09-25-feat_add_allow_list_field_api_keys
branch
from
September 26, 2025 14:00
f1a4e56 to
a591e0a
Compare
ThomasK33
force-pushed
the
thomask33/09-25-resource_scoped_api_keys_in_codersdk
branch
from
September 26, 2025 14:00
6d17ef1 to
6fa5fe1
Compare
ThomasK33
force-pushed
the
thomask33/09-25-feat_add_allow_list_field_api_keys
branch
2 times, most recently
from
October 3, 2025 17:59
5dd3400 to
5a6e8cc
Compare
ThomasK33
force-pushed
the
thomask33/09-25-resource_scoped_api_keys_in_codersdk
branch
from
October 3, 2025 17:59
d38ed5b to
5cb53f7
Compare
ThomasK33
force-pushed
the
thomask33/09-25-feat_add_allow_list_field_api_keys
branch
from
October 6, 2025 09:42
5a6e8cc to
73a65fa
Compare
ThomasK33
force-pushed
the
thomask33/09-25-resource_scoped_api_keys_in_codersdk
branch
from
October 6, 2025 09:42
5cb53f7 to
6248fff
Compare
ThomasK33
force-pushed
the
thomask33/09-25-feat_add_allow_list_field_api_keys
branch
2 times, most recently
from
October 6, 2025 10:09
7d422aa to
d590c1d
Compare
ThomasK33
force-pushed
the
thomask33/09-25-resource_scoped_api_keys_in_codersdk
branch
from
October 6, 2025 10:09
6248fff to
67ed32b
Compare
ThomasK33
force-pushed
the
thomask33/09-25-feat_add_allow_list_field_api_keys
branch
from
October 6, 2025 10:35
d590c1d to
49af2b4
Compare
ThomasK33
force-pushed
the
thomask33/09-25-resource_scoped_api_keys_in_codersdk
branch
2 times, most recently
from
October 6, 2025 11:18
4beef99 to
86f7de9
Compare
ThomasK33
force-pushed
the
thomask33/09-25-feat_add_allow_list_field_api_keys
branch
from
October 6, 2025 11:57
49af2b4 to
fa53285
Compare
ThomasK33
force-pushed
the
thomask33/09-25-resource_scoped_api_keys_in_codersdk
branch
from
October 6, 2025 11:57
86f7de9 to
854efb0
Compare
ThomasK33
force-pushed
the
thomask33/09-25-feat_add_allow_list_field_api_keys
branch
from
October 6, 2025 21:16
fa53285 to
d7df2aa
Compare
ThomasK33
force-pushed
the
thomask33/09-25-resource_scoped_api_keys_in_codersdk
branch
2 times, most recently
from
October 6, 2025 21:40
87fb51c to
3bdb267
Compare
Emyrk
reviewed
Oct 7, 2025
ThomasK33
force-pushed
the
thomask33/09-25-feat_add_allow_list_field_api_keys
branch
from
October 7, 2025 16:38
d7df2aa to
a1346f5
Compare
Emyrk
requested changes
Oct 9, 2025
This was referenced Oct 9, 2025
Emyrk
reviewed
Oct 15, 2025
Emyrk
reviewed
Oct 23, 2025
Add allow_list field to API key data structures and ensure proper JSON serialization across backend and frontend. Initialize with default wildcard entry (*:*) for backward compatibility with existing API keys that don't have explicit resource restrictions. Fixes #19854
Emyrk
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Add API key allow list to the SDK
This PR adds an allow list to API keys in the SDK. The allow list is a list of targets that the API key is allowed to access. If the allow list is empty, a default allow list with a single entry that allows access to all resources is created.
The changes include:
Fixes #19854