fix: pin pg_dump version when generating schema#19696
Merged
Merged
Conversation
ethanndickson
force-pushed
the
ethan/pg-dump-pin
branch
from
September 4, 2025 03:31
9ed9a49 to
45f79b9
Compare
ethanndickson
changed the title
ethanndickson
force-pushed
the
ethan/pg-dump-pin
branch
2 times, most recently
from
September 4, 2025 03:33
ed453b2 to
7cceb5f
Compare
stirby
approved these changes
Sep 4, 2025
ethanndickson
marked this pull request as ready for review
September 4, 2025 03:36
ethanndickson
force-pushed
the
ethan/pg-dump-pin
branch
2 times, most recently
from
September 4, 2025 03:43
e56a33b to
e56e8f1
Compare
ethanndickson
force-pushed
the
ethan/pg-dump-pin
branch
from
September 4, 2025 03:48
e56e8f1 to
aeabc50
Compare
ethanndickson
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest release of all
pg_dumpmajor versions, going back to 13, started inserting\restrict\unrestrictkeywords into dumps. This currently breaks sqlc ingen/dumpand our check migration script. Full details of the postgres change are available here: https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=575f54d4cTo fix, we'll always use the
pg_dumpin our postgres 13.21 docker image for schema dumps, instead of what's on the runner/local machine.Coder doesn't restore from postgres dumps, so we're not vulnerable to attacks that would be patched by the latest postgres version. Regardless, we'll unpin ASAP.
Once sqlc is updated to handle these keywords, we need to start stripping them when comparing the schema in the migration check script, and then we can unpin the pg_dump version. This is being tracked at coder/internal#965