refactor: replace OAuth2 callback_url with RFC 6749 compliant redirect_uris#18810
Conversation
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ThomasK33
force-pushed
the
thomask33/07-07-feat_standardize_oauth2_endpoints_and_add_token_revocation
branch
from
July 9, 2025 12:16
dd9cb2f to
ae754f4
Compare
ThomasK33
force-pushed
the
thomask33/07-08-feat_replace_callback_url_with_redirect_uris_for_oauth2_rfc_6749_compliance
branch
from
July 9, 2025 12:16
f9e6552 to
1444efe
Compare
ThomasK33
changed the base branch from
thomask33/07-07-feat_standardize_oauth2_endpoints_and_add_token_revocation
to
graphite-base/18810
July 9, 2025 15:19
ThomasK33
force-pushed
the
thomask33/07-08-feat_replace_callback_url_with_redirect_uris_for_oauth2_rfc_6749_compliance
branch
from
July 9, 2025 22:21
1444efe to
ef4a6c8
Compare
ThomasK33
force-pushed
the
graphite-base/18810
branch
from
July 9, 2025 22:21
ae754f4 to
ab73979
Compare
ThomasK33
changed the base branch from
graphite-base/18810
to
thomask33/07-07-feat_standardize_oauth2_endpoints_and_add_token_revocation
July 9, 2025 22:21
ThomasK33
force-pushed
the
thomask33/07-08-feat_replace_callback_url_with_redirect_uris_for_oauth2_rfc_6749_compliance
branch
from
July 10, 2025 09:15
ef4a6c8 to
e24c4b5
Compare
ThomasK33
marked this pull request as ready for review
July 10, 2025 09:25
ThomasK33
force-pushed
the
thomask33/07-08-feat_replace_callback_url_with_redirect_uris_for_oauth2_rfc_6749_compliance
branch
from
July 12, 2025 12:55
e24c4b5 to
98e7f95
Compare
ThomasK33
force-pushed
the
thomask33/07-07-feat_standardize_oauth2_endpoints_and_add_token_revocation
branch
from
July 12, 2025 12:55
ab73979 to
b89c367
Compare
ThomasK33
force-pushed
the
thomask33/07-07-feat_standardize_oauth2_endpoints_and_add_token_revocation
branch
from
July 14, 2025 12:43
b89c367 to
b73b71d
Compare
ThomasK33
force-pushed
the
thomask33/07-08-feat_replace_callback_url_with_redirect_uris_for_oauth2_rfc_6749_compliance
branch
from
July 14, 2025 12:43
98e7f95 to
2792051
Compare
This was referenced Jul 14, 2025
ThomasK33
changed the base branch from
thomask33/07-07-feat_standardize_oauth2_endpoints_and_add_token_revocation
to
graphite-base/18810
July 14, 2025 15:16
ThomasK33
force-pushed
the
thomask33/07-08-feat_replace_callback_url_with_redirect_uris_for_oauth2_rfc_6749_compliance
branch
from
July 14, 2025 16:22
2792051 to
3dd0c37
Compare
ThomasK33
force-pushed
the
graphite-base/18810
branch
from
July 14, 2025 16:22
b73b71d to
386d77d
Compare
ThomasK33
changed the base branch from
graphite-base/18810
to
thomask33/07-07-feat_standardize_oauth2_endpoints_and_add_token_revocation
July 14, 2025 16:22
ThomasK33
force-pushed
the
thomask33/07-07-feat_standardize_oauth2_endpoints_and_add_token_revocation
branch
from
July 14, 2025 17:18
386d77d to
b58eed8
Compare
ThomasK33
force-pushed
the
thomask33/07-08-feat_replace_callback_url_with_redirect_uris_for_oauth2_rfc_6749_compliance
branch
from
July 14, 2025 17:18
3dd0c37 to
962c22c
Compare
ThomasK33
changed the base branch from
thomask33/07-07-feat_standardize_oauth2_endpoints_and_add_token_revocation
to
graphite-base/18810
July 15, 2025 16:03
ThomasK33
force-pushed
the
thomask33/07-08-feat_replace_callback_url_with_redirect_uris_for_oauth2_rfc_6749_compliance
branch
from
August 12, 2025 16:30
055d631 to
bdc94d5
Compare
ThomasK33
force-pushed
the
graphite-base/18810
branch
from
August 12, 2025 16:30
9dfcc8a to
aca2f6a
Compare
ThomasK33
changed the base branch from
graphite-base/18810
to
thomask33/07-07-feat_standardize_oauth2_endpoints_and_add_token_revocation
August 12, 2025 16:30
ThomasK33
changed the base branch from
thomask33/07-07-feat_standardize_oauth2_endpoints_and_add_token_revocation
to
graphite-base/18810
August 12, 2025 16:49
ThomasK33
force-pushed
the
thomask33/07-08-feat_replace_callback_url_with_redirect_uris_for_oauth2_rfc_6749_compliance
branch
from
August 12, 2025 16:58
bdc94d5 to
67bf443
Compare
ThomasK33
force-pushed
the
graphite-base/18810
branch
from
August 12, 2025 16:58
aca2f6a to
35d7f5a
Compare
ThomasK33
changed the base branch from
graphite-base/18810
to
thomask33/07-07-feat_standardize_oauth2_endpoints_and_add_token_revocation
August 12, 2025 16:58
ThomasK33
deleted the
thomask33/07-08-feat_replace_callback_url_with_redirect_uris_for_oauth2_rfc_6749_compliance
branch
September 15, 2025 07:52
ThomasK33
restored the
thomask33/07-08-feat_replace_callback_url_with_redirect_uris_for_oauth2_rfc_6749_compliance
branch
September 15, 2025 07:54
ThomasK33
force-pushed
the
thomask33/07-07-feat_standardize_oauth2_endpoints_and_add_token_revocation
branch
from
October 10, 2025 14:42
35d7f5a to
8b4b6f0
Compare
ThomasK33
force-pushed
the
thomask33/07-08-feat_replace_callback_url_with_redirect_uris_for_oauth2_rfc_6749_compliance
branch
from
October 10, 2025 14:42
67bf443 to
7b4150a
Compare
ThomasK33
force-pushed
the
thomask33/07-07-feat_standardize_oauth2_endpoints_and_add_token_revocation
branch
from
October 10, 2025 14:53
8b4b6f0 to
81adc67
Compare
ThomasK33
force-pushed
the
thomask33/07-08-feat_replace_callback_url_with_redirect_uris_for_oauth2_rfc_6749_compliance
branch
from
October 10, 2025 14:53
7b4150a to
be56098
Compare
…pliance Change-Id: I4823e475777ebdf75e3a80e47ff6bef1a556cd55 Signed-off-by: Thomas Kosiewski <tk@coder.com>
ThomasK33
force-pushed
the
thomask33/07-08-feat_replace_callback_url_with_redirect_uris_for_oauth2_rfc_6749_compliance
branch
from
October 10, 2025 14:57
be56098 to
d00dd0b
Compare
Member
|
Removing my review due to PR being stale, feel free to add me back if this becomes relevant again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 6749 Compliance: Replace callback_url with redirect_uris Array
This PR improves OAuth2 provider compliance with RFC 6749 by replacing the single
callback_urlfield with a properredirect_urisarray. This change allows OAuth2 clients to register multiple valid redirect URIs and enforces exact URI matching as required by the specification.Key changes:
callback_urlcolumn and makeredirect_uristhe source of truthThis change improves security by enforcing stricter redirect URI validation and provides more flexibility for OAuth2 clients that need multiple callback endpoints.