Skip to content

chore: add users link to nav bar - #1797

Merged
Kira-Pilot merged 3 commits into
mainfrom
add-users-nav-link/kira-pilot
May 26, 2022
Merged

Kira-Pilot merged 3 commits into
mainfrom
add-users-nav-link/kira-pilot

Conversation

@Kira-Pilot

@Kira-Pilot Kira-Pilot commented May 26, 2022 •

Copy link
Copy Markdown
Contributor

resolves #1746
Screen Shot 2022-05-26 at 2 41 29 PM

Is it best to use Chromatic when trying to look at the Users page thru the eyes of different roles? I note I can't make new users in master.cdr.dev.

@Kira-Pilot
Kira-Pilot requested a review from a team as a code owner May 26, 2022 18:43
workspaces: "Workspaces",
templates: "Templates",
users: "Users",
}

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is overkill, just say the word. Was thinking about future us and our translated UI.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Praise: Looks great to me!

@Kira-Pilot

Copy link
Copy Markdown
Contributor Author

@vapurrmaid do you mind doing a Chromatic review? Or is that something I can do myself?

@greyscaled

Copy link
Copy Markdown
Contributor

@vapurrmaid do you mind doing a Chromatic review? Or is that something I can do myself?

For a change like this, feel free to self-review for sure!

@Kira-Pilot
Kira-Pilot merged commit b4c41d3 into main May 26, 2022
@Kira-Pilot
Kira-Pilot deleted the add-users-nav-link/kira-pilot branch May 26, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

All org users should have access to the user list for their own org in the UI

2 participants