Repository navigation
fix: update workspace form fields when switching templates - #1761
Merged
Kira-Pilot merged 1 commit intoMay 26, 2022
Merged
Conversation
kylecarbs
approved these changes
May 25, 2022
Kira-Pilot
deleted the
update-workspace-fields-on-template-switch/kira-pilot
branch
May 26, 2022 12:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1716
The fix took 10 minutes; trying to write a test took a lot longer and I finally gave up. How the heck do you switch the input in an MUI
TextField?Given a
TextFieldwithinputProps={{ "data-testid": "template-select" }}Something like:
seems to work - everything passes - but schema description text just doesn't show up, even with everything mocked out.
Also, is there a reason we aren't using MUI Select? IDK if that would make this any easier; just curious.