Skip to content

feat: add terminal links - #1636

Merged
code-asher merged 2 commits into
mainfrom
code-asher/terminal-links
May 23, 2022
Merged

code-asher merged 2 commits into
mainfrom
code-asher/terminal-links

Conversation

@code-asher

@code-asher code-asher commented May 20, 2022 •

Copy link
Copy Markdown
Member

terminal-links

Closes #760

@code-asher
code-asher force-pushed the code-asher/terminal-links branch from 37f04bd to afa679a Compare May 20, 2022 19:28
@code-asher
code-asher marked this pull request as ready for review May 20, 2022 19:44
@code-asher
code-asher requested a review from a team as a code owner May 20, 2022 19:44
@code-asher

code-asher commented May 20, 2022 •

Copy link
Copy Markdown
Member Author

It occurs to me that maybe I should only show the link if the status is "connected"?

@greyscaled

Copy link
Copy Markdown
Contributor

It occurs to me that maybe I should only show the link if the status is "connected"?

fair enough

@ammario

ammario commented May 21, 2022 •

Copy link
Copy Markdown
Member

Why not make it a button 😬?

Also, I think it could be shortened "Open Terminal" or even just "Terminal".

@ammario

ammario commented May 23, 2022

Copy link
Copy Markdown
Member

Also resolves #265

@code-asher
code-asher force-pushed the code-asher/terminal-links branch from 55081d5 to d59d94d Compare May 23, 2022 20:31
@code-asher

code-asher commented May 23, 2022 •

Copy link
Copy Markdown
Member Author

Button and text change seems chill to me, gonna add a note on #1648

@code-asher
code-asher force-pushed the code-asher/terminal-links branch from d59d94d to 8a31fe9 Compare May 23, 2022 20:34
@code-asher
code-asher merged commit dd4bb07 into main May 23, 2022
@code-asher
code-asher deleted the code-asher/terminal-links branch May 23, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add the web terminal to the workspaces Application card

4 participants