Repository navigation
feat: add terminal links - #1636
Merged
Merged
Conversation
code-asher
force-pushed
the
code-asher/terminal-links
branch
from
May 20, 2022 19:28
37f04bd to
afa679a
Compare
code-asher
marked this pull request as ready for review
May 20, 2022 19:44
greyscaled
approved these changes
May 20, 2022
Member
Author
|
It occurs to me that maybe I should only show the link if the status is "connected"? |
Kira-Pilot
approved these changes
May 20, 2022
Contributor
fair enough |
Member
|
Why not make it a button 😬? Also, I think it could be shortened "Open Terminal" or even just "Terminal". |
Member
|
Also resolves #265 |
code-asher
force-pushed
the
code-asher/terminal-links
branch
from
May 23, 2022 20:31
55081d5 to
d59d94d
Compare
Member
Author
|
Button and text change seems chill to me, gonna add a note on #1648 |
code-asher
force-pushed
the
code-asher/terminal-links
branch
from
May 23, 2022 20:34
d59d94d to
8a31fe9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #760