Skip to content

chore: use docker host in docker-compose - #1592

Merged
bpmct merged 3 commits into
mainfrom
bpmct/docker-vars
May 19, 2022
Merged

bpmct merged 3 commits into
mainfrom
bpmct/docker-vars

Conversation

@bpmct

@bpmct bpmct commented May 19, 2022 •

Copy link
Copy Markdown
Member

This PR adds support for passing through CODER_ACCESS_URL in docker-compose, and also defaults to the docker host.

This is somewhat a revert of #1507, but it was also its initial implementation. I think this is an acceptable standard for the following reasons:

  • The absence of an access URL in docker-compose results in 0 functioning example templates
  • The docker host as an access URL in docker-compose results in 2 functioning example templates (docker, docker-builds)
  • Users will be required to set an access URL anyways to use all other example templates. Warn users if their access URL is localhost or 127.0.0.1 #1528 proposes a warning for this anyways
  • Docker template users will not experience breaking changes if they have a functional access URL (this already happened!)

Related discussions: #1545, #1528, #1345, #1545

@bpmct bpmct self-assigned this May 19, 2022
Comment thread docker-compose.yaml
services:
coder:
image: ghcr.io/coder/coder:v${CODER_VERSION:-0.5.6}-${ARCH:-amd64}
image: ghcr.io/coder/coder:v${CODER_VERSION:-0.5.10}-${ARCH:-amd64}

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish dependabot/dependabot-core#390 existed. Maybe we use Renovate or another tool?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we've even got 0.5.11 right now!

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems the release was deleted: https://github.com/coder/coder/releases/

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point then!

@bpmct
bpmct requested a review from johnstcn May 19, 2022 16:10

@johnstcn johnstcn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm completely happy with this approach instead.

@mafredri mafredri left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb! 🎉

@bpmct
bpmct merged commit c47b6f0 into main May 19, 2022
@bpmct
bpmct deleted the bpmct/docker-vars branch May 19, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants