Repository navigation
chore: use docker host in docker-compose - #1592
Merged
Merged
Conversation
bpmct
commented
May 19, 2022
| services: | ||
| coder: | ||
| image: ghcr.io/coder/coder:v${CODER_VERSION:-0.5.6}-${ARCH:-amd64} | ||
| image: ghcr.io/coder/coder:v${CODER_VERSION:-0.5.10}-${ARCH:-amd64} |
Member
Author
There was a problem hiding this comment.
I wish dependabot/dependabot-core#390 existed. Maybe we use Renovate or another tool?
Member
There was a problem hiding this comment.
I think we've even got 0.5.11 right now!
Member
Author
There was a problem hiding this comment.
it seems the release was deleted: https://github.com/coder/coder/releases/
johnstcn
approved these changes
May 19, 2022
johnstcn
left a comment
Member
There was a problem hiding this comment.
I'm completely happy with this approach instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for passing through
CODER_ACCESS_URLin docker-compose, and also defaults to the docker host.This is somewhat a revert of #1507, but it was also its initial implementation. I think this is an acceptable standard for the following reasons:
Related discussions: #1545, #1528, #1345, #1545