Skip to content

fix: Use Terraform address to index resource + agent association - #1577

Merged
kylecarbs merged 1 commit into
mainfrom
tfmodresources
May 18, 2022
Merged

kylecarbs merged 1 commit into
mainfrom
tfmodresources

Conversation

@kylecarbs

Copy link
Copy Markdown
Member

This fixes resources created from Terraform modules not
properly being associated with an agent.

By not using the address, and resource identifiers prefixed
with module.<name> would be missed!

This fixes resources created from Terraform modules not
properly being associated with an agent.

By not using the address, and resource identifiers prefixed
with `module.<name>` would be missed!
@kylecarbs
kylecarbs requested a review from Emyrk May 18, 2022 20:44
@kylecarbs kylecarbs self-assigned this May 18, 2022
@kylecarbs
kylecarbs requested a review from coadler May 18, 2022 21:07
@kylecarbs
kylecarbs merged commit f3fe2a0 into main May 18, 2022
@kylecarbs
kylecarbs deleted the tfmodresources branch May 18, 2022 21:26
johnstcn added a commit that referenced this pull request May 19, 2022
johnstcn added a commit that referenced this pull request May 19, 2022
kylecarbs added a commit that referenced this pull request May 24, 2022
Closes #1705.

There was an issue in the implementation brought by #1577 by not trimming
the array value when resources use counts. This should fix it, and adds
a test to be sure!
kylecarbs added a commit that referenced this pull request May 25, 2022
Closes #1705.

There was an issue in the implementation brought by #1577 by not trimming
the array value when resources use counts. This should fix it, and adds
a test to be sure!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants