Skip to content

fix: More robust provisionersdk agent init scripts - #1551

Merged
mafredri merged 5 commits into
mainfrom
mafredri/improve-provisionersdk-agent-scripts
May 19, 2022
Merged

mafredri merged 5 commits into
mainfrom
mafredri/improve-provisionersdk-agent-scripts

Conversation

@mafredri

@mafredri mafredri commented May 18, 2022 •

Copy link
Copy Markdown
Member

This PR makes the provisionersdk agent init scripts a bit more robust (mostly on Linux).

  • Try wget and busybox wget instead of just curl
  • More verbose shell output via -x
  • Handle mktemp limitation on busybox by adding one X in template

Related #1544

Tested on:

  • alpine:latest
  • codercom/enterprise-base:ubuntu

@mafredri mafredri self-assigned this May 18, 2022
@mafredri
mafredri requested review from a team and johnstcn May 18, 2022 14:24

@kylecarbs kylecarbs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooooo very nice!

@deansheather deansheather left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any usages of quotes should be surrounded in quotes IMO (except for the variable setting case when not using export)

Comment thread provisionersdk/agent.go Resolved
Comment thread provisionersdk/agent.go Resolved
Comment thread provisionersdk/agent.go Resolved
Comment thread provisionersdk/agent.go Resolved
Comment thread provisionersdk/agent.go Resolved
Comment thread provisionersdk/agent.go Resolved
mafredri and others added 3 commits May 18, 2022 18:09
Co-authored-by: Dean Sheather <dean@deansheather.com>
Co-authored-by: Dean Sheather <dean@deansheather.com>

@johnstcn johnstcn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@mafredri
mafredri enabled auto-merge (squash) May 19, 2022 12:51
@mafredri
mafredri merged commit ad9bdb7 into main May 19, 2022
@mafredri
mafredri deleted the mafredri/improve-provisionersdk-agent-scripts branch May 19, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants