Skip to content

examples/docker-local: add explanatory comment - #1545

Merged
johnstcn merged 1 commit into
mainfrom
cj/docker-local-doc
May 18, 2022
Merged

johnstcn merged 1 commit into
mainfrom
cj/docker-local-doc

Conversation

@johnstcn

Copy link
Copy Markdown
Member

Adds a comment to the docker-local example template regarding coder.url and pointing users to edit the URL to their environment.

@johnstcn johnstcn self-assigned this May 18, 2022

@bpmct bpmct left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish there was a way we could programmatically detect this, but this makes sense and I imagine it'd work in most cases. 👍🏼

The sucky thing about running docker-compose locally is the docker example is the only one that works.

@johnstcn
johnstcn merged commit 13571b0 into main May 18, 2022
@johnstcn
johnstcn deleted the cj/docker-local-doc branch May 18, 2022 16:10
@coadler

coadler commented May 18, 2022 •

Copy link
Copy Markdown
Contributor

cc @johnstcn @bpmct Can we have a docker-compose specific template? docker-local used to work just fine without coderd being run in docker-compose and this sort of broke my workflow, and seems like an odd default.

@johnstcn

Copy link
Copy Markdown
Member Author

@coadler we could instead set the access URL of coder to https://host.docker.internal:7080 in docker-compose.yaml as per my original proposed change (e699ba1)

@coadler

coadler commented May 18, 2022

Copy link
Copy Markdown
Contributor

@coadler we could instead set the access URL of coder to https://host.docker.internal:7080 in docker-compose.yaml as per my original proposed change (e699ba1)

I think that seems reasonable too!

@bpmct

bpmct commented May 18, 2022

Copy link
Copy Markdown
Member

@coadler we could instead set the access URL of coder to https://host.docker.internal:7080 in docker-compose.yaml as per my original proposed change (e699ba1)

I agree we should do this instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants