Skip to content

chore(cli): drop 'notification' prefix for configuring email auth - #15270

Merged
DanielleMaywood merged 5 commits into
mainfrom
dm-cli-email-prefix
Oct 30, 2024
Merged

DanielleMaywood merged 5 commits into
mainfrom
dm-cli-email-prefix

Conversation

@DanielleMaywood

Copy link
Copy Markdown
Collaborator

Closes #14644

@DanielleMaywood
DanielleMaywood marked this pull request as ready for review October 29, 2024 14:58
@DanielleMaywood
DanielleMaywood marked this pull request as draft October 29, 2024 15:04
@DanielleMaywood
DanielleMaywood marked this pull request as ready for review October 29, 2024 15:58

@SasSwart SasSwart left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with just one question. Will leave it to someone who's been here a bit longer to actually approve for now.

Comment thread cli/testdata/server-config.yaml.golden Resolved

@mafredri mafredri left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor nit about struct field name, otherwise LGTM 👍🏻

hello: localhost
# Force a TLS connection to the configured SMTP smarthost.
# (default: false, type: bool)
# (default: <unset>, type: bool)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably start adding the deprecation notice to these comments at some point 🤔

Comment thread codersdk/deployment.go
Description: "The sender's address to use.",
Flag: "email-from",
Env: "CODER_EMAIL_FROM",
Value: &c.Notifications.SMTP.From,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we keeping .Notifications here? Rename to email?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept .Notifications for now because separating out SMTP from it would be a larger refactor and at the moment we only use SMTP for notifications so didn't think it warranted being put into this PR.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, fair enough 👍🏻. Not a pressing issue but worth doing at some point to match the configuration.

@DanielleMaywood
DanielleMaywood merged commit 823a2ea into main Oct 30, 2024
@DanielleMaywood
DanielleMaywood deleted the dm-cli-email-prefix branch October 30, 2024 10:06
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLI: Drop the 'notification' prefix on cli options for configuring email auth

3 participants