Repository navigation
chore(cli): drop 'notification' prefix for configuring email auth - #15270
Conversation
SasSwart
left a comment
There was a problem hiding this comment.
LGTM, with just one question. Will leave it to someone who's been here a bit longer to actually approve for now.
mafredri
left a comment
There was a problem hiding this comment.
Just a minor nit about struct field name, otherwise LGTM 👍🏻
| hello: localhost | ||
| # Force a TLS connection to the configured SMTP smarthost. | ||
| # (default: false, type: bool) | ||
| # (default: <unset>, type: bool) |
There was a problem hiding this comment.
We should probably start adding the deprecation notice to these comments at some point 🤔
| Description: "The sender's address to use.", | ||
| Flag: "email-from", | ||
| Env: "CODER_EMAIL_FROM", | ||
| Value: &c.Notifications.SMTP.From, |
There was a problem hiding this comment.
Why are we keeping .Notifications here? Rename to email?
There was a problem hiding this comment.
I kept .Notifications for now because separating out SMTP from it would be a larger refactor and at the moment we only use SMTP for notifications so didn't think it warranted being put into this PR.
There was a problem hiding this comment.
Alright, fair enough 👍🏻. Not a pressing issue but worth doing at some point to match the configuration.
Closes #14644