Skip to content

chore: validate docs - #1485

Merged
khorne3 merged 6 commits into
mainfrom
readme-review
May 19, 2022
Merged

khorne3 merged 6 commits into
mainfrom
readme-review

Conversation

@khorne3

@khorne3 khorne3 commented May 16, 2022

Copy link
Copy Markdown
Contributor

This PR updates the usage instructions in the README. A bit verbose, but attempting to catch all the gotchas ahead of time.

Fixes #1302

@khorne3
khorne3 requested review from bpmct and removed request for bpmct May 16, 2022 18:14
Comment thread docs/workspaces.md Resolved
@khorne3
khorne3 marked this pull request as ready for review May 16, 2022 18:44
Comment thread docs/README.md Resolved
Comment thread docs/README.md Resolved
Comment thread docs/README.md Resolved

@bpmct bpmct left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think this improves readability

Comment thread docs/README.md Resolved
@khorne3
khorne3 requested review from bpmct and kylecarbs May 17, 2022 13:39
@khorne3
khorne3 merged commit 6f96921 into main May 19, 2022
@khorne3
khorne3 deleted the readme-review branch May 19, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Verified ability to install and run using only docs for switch to public

4 participants