Repository navigation
fix: remove unimplemented account links - #1411
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1411 +/- ##
==========================================
- Coverage 67.29% 67.23% -0.06%
==========================================
Files 288 286 -2
Lines 19109 19097 -12
Branches 241 241
==========================================
- Hits 12859 12840 -19
- Misses 4936 4938 +2
- Partials 1314 1319 +5
Continue to review full report at Codecov.
|
It appears unclear as of now when/if these will be implemented so I opted to remove them (as opposed to commenting them out) to avoid having them rot (they are easily added back anyway). Closes #1232.
code-asher
force-pushed
the
asher/remove-account-links
branch
from
May 12, 2022 17:25
1249b52 to
2162785
Compare
code-asher
marked this pull request as ready for review
May 12, 2022 18:05
kylecarbs
approved these changes
May 12, 2022
presleyp
approved these changes
May 12, 2022
Kira-Pilot
approved these changes
May 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears unclear as of now when/if these will be implemented so I
opted to remove them (as opposed to commenting them out) to avoid having
them rot (they are easily added back anyway).
Closes #1232.