feat(site): edit organization member roles#13977
Merged
Merged
Conversation
aslilac
commented
Jul 22, 2024
aslilac
commented
Member
BrunoQuaresma
left a comment
BrunoQuaresma
left a comment
Contributor
There was a problem hiding this comment.
Code looks good 👍 but I'm missing the tests.
This comment was marked as resolved.
This comment was marked as resolved.
Member
Author
|
Fixed up 1, 2, and 4. As for 3,
This would require a fair bit of backend work. Especially for custom roles, I think letting admins enter a role description and surfacing that on the frontend is a good idea, but non-trivial to add. |
BrunoQuaresma
approved these changes
Jul 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.