Skip to content

fix: macOS backspace processing - #1379

Merged
spikecurtis merged 1 commit into
mainfrom
spike/1226-revert-long-lines-fix
May 10, 2022
Merged

spikecurtis merged 1 commit into
mainfrom
spike/1226-revert-long-lines-fix

Conversation

@spikecurtis

Copy link
Copy Markdown
Collaborator

Revert "fix: Remove line length limit on MacOS for input prompts (#839)"

This reverts commit ccba2ba from #839 but which introduced bug #1226

Fixes #1226

Revert "fix: Remove line length limit on MacOS for input prompts (#839)"

This reverts commit ccba2ba.
@spikecurtis
spikecurtis requested a review from kylecarbs May 10, 2022 22:06
@spikecurtis spikecurtis self-assigned this May 10, 2022

@kylecarbs kylecarbs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov

codecov Bot commented May 10, 2022 •

Copy link
Copy Markdown

Codecov Report

Merging #1379 (b3f1899) into main (f816bbe) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1379      +/-   ##
==========================================
- Coverage   66.94%   66.93%   -0.01%     
==========================================
  Files         290      288       -2     
  Lines       18885    18856      -29     
  Branches      241      241              
==========================================
- Hits        12642    12621      -21     
+ Misses       4956     4943      -13     
- Partials     1287     1292       +5     
Flag Coverage Δ
unittest-go-macos-latest 54.01% <ø> (+0.06%) ⬆️
unittest-go-postgres- 65.38% <ø> (-0.07%) ⬇️
unittest-go-ubuntu-latest 56.41% <ø> (-0.01%) ⬇️
unittest-go-windows-2022 52.38% <ø> (+<0.01%) ⬆️
unittest-js 74.24% <ø> (ø)
Impacted Files Coverage Δ
cli/cliui/prompt.go 76.47% <ø> (+6.57%) ⬆️
codersdk/provisionerdaemons.go 61.97% <0.00%> (-5.64%) ⬇️
peerbroker/listen.go 84.03% <0.00%> (-3.37%) ⬇️
cli/cliui/provisionerjob.go 76.42% <0.00%> (-2.15%) ⬇️
coderd/workspaceagents.go 56.04% <0.00%> (-1.87%) ⬇️
provisionerd/provisionerd.go 76.30% <0.00%> (-1.34%) ⬇️
peer/conn.go 80.34% <0.00%> (ø)
agent/agent.go 67.14% <0.00%> (ø)
coderd/httpapi/httpapi.go 77.50% <0.00%> (+6.25%) ⬆️
provisionersdk/serve.go 43.24% <0.00%> (+8.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f816bbe...b3f1899. Read the comment docs.

@spikecurtis
spikecurtis merged commit 9d94f4f into main May 10, 2022
@spikecurtis
spikecurtis deleted the spike/1226-revert-long-lines-fix branch May 10, 2022 22:20
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: can't use Backspace in "Specify a name for your workspace"

3 participants