Repository navigation
feat: arm(v7/64) builds for releases and agent scripts - #1337
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1337 +/- ##
==========================================
+ Coverage 66.44% 67.01% +0.56%
==========================================
Files 284 288 +4
Lines 18584 18857 +273
Branches 235 241 +6
==========================================
+ Hits 12349 12637 +288
+ Misses 4967 4932 -35
- Partials 1268 1288 +20
Continue to review full report at Codecov.
|
|
@kylecarbs I think the Terraform provider has to be updated support Oh, and the agent scripts: Lines 21 to 30 in b948f2d I also noticed that the binary isn't being uploaded to Edit: I think it has to do with the coder slim build only building amd64 binaries. I'll test in the morning Lines 29 to 39 in ad8d9dd |
|
still need to a bit of work to expose the agent start script |
|
Testing with my raspberry pi now :) Edit: Running into an issue parsing templates Edit 2: got this working! |
|
So, just a few doubts - but I will test this.
|
All great questions.
|
|
Thanks for the answers, I will start my build now. |
I know how to modify the main.tf if that's what you mean. What I will have to do(i hope it's right) is go to Docker Hub and find an ARM64(my pi is 64-bit ARM) image. Then, I should add that image name to its respective section in the main.tf file. Then I should create a workspace. Am I right on this? |
Correct. That image needs to have
Yeah, I initially submitted this to add support for armv7 but it grew in scope when I realized the arm64 scripts weren't being added |
| # The "trimprefix" appends ".exe" on Windows. | ||
| post: | | ||
| cp {{.Path}} site/out/bin/coder-{{ .Os }}-{{ .Arch }}{{ trimprefix .Name "coder" }} | ||
| cp {{.Path}} site/out/bin/coder-{{ .Os }}-{{ .Arch }}{{ if .Arm }}v{{ .Arm }}{{ end }}{{ trimprefix .Name "coder" }} |
There was a problem hiding this comment.
I discovered this is fairly common: https://sourcegraph.com/search?q=context:global+file:.goreleaser.yaml+%7B%7B+.Arm+%7D%7D&patternType=literal
|
Umm.... We got a situation here. I am encountering this: Any solutions? My Pi's Neofetch if it helps: |
Apologies! This is a known issue and a bug in the upstream Terraform library. Installing Terraform on your Pi will fix this as a workaround. |
|
10-4! I am going outside now, but I will try when I'm back! Thanks for that clue!
|
|
I know this is merged and all that, but @bpmct did it work properly for you? I inserted custom images that use Ubuntu ARM, two from Canonical's kinda proxies ARMv8 provider(that's arm64, if I am not wrong) and one from a person or org named osrf. All of them failed, so are there any working images that use ARM64? |
|
@im-coder-lg can we discuss this in your issue or in Discord? |

This PR adds builds armv7 Linux releases. Most notably, this will improve support for Raspberry Pi operating systems
Fixes #1336