Skip to content

fix: Remove microsecond wait in peer.(*Channel) - #1270

Merged
kylecarbs merged 1 commit into
mainfrom
peerrace
May 3, 2022
Merged

kylecarbs merged 1 commit into
mainfrom
peerrace

Conversation

@kylecarbs

Copy link
Copy Markdown
Member

This was implemented when our WebRTC code was much less hardened.
It's likely this was a cause of some other problem.

Closes #1076.

This was implemented when our WebRTC code was much less hardened.
It's likely this was a cause of some other problem.

Closes #1076.
@kylecarbs
kylecarbs requested a review from coadler May 3, 2022 13:55
@kylecarbs kylecarbs self-assigned this May 3, 2022
@codecov

codecov Bot commented May 3, 2022 •

Copy link
Copy Markdown

Codecov Report

Merging #1270 (815ef0b) into main (5dcaf94) will decrease coverage by 0.29%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1270      +/-   ##
==========================================
- Coverage   66.10%   65.81%   -0.30%     
==========================================
  Files         276      273       -3     
  Lines       18146    18024     -122     
  Branches      216      216              
==========================================
- Hits        11996    11863     -133     
- Misses       4911     4923      +12     
+ Partials     1239     1238       -1     
Flag Coverage Δ
unittest-go-macos-latest 53.16% <ø> (-0.05%) ⬇️
unittest-go-postgres- 64.87% <ø> (-0.24%) ⬇️
unittest-go-ubuntu-latest 55.75% <ø> (+<0.01%) ⬆️
unittest-go-windows-2022 ?
unittest-js 70.69% <ø> (ø)
Impacted Files Coverage Δ
peer/channel.go 85.96% <ø> (+0.99%) ⬆️
cli/configssh.go 62.04% <0.00%> (-6.57%) ⬇️
peerbroker/dial.go 77.04% <0.00%> (-6.56%) ⬇️
codersdk/provisionerdaemons.go 61.97% <0.00%> (-5.64%) ⬇️
pty/ptytest/ptytest.go 86.95% <0.00%> (-4.35%) ⬇️
peer/conn.go 77.39% <0.00%> (-4.20%) ⬇️
cli/templateinit.go 58.62% <0.00%> (-3.45%) ⬇️
agent/agent.go 64.04% <0.00%> (-3.10%) ⬇️
provisionerd/provisionerd.go 75.76% <0.00%> (-2.41%) ⬇️
provisioner/echo/serve.go 54.40% <0.00%> (-2.40%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dcaf94...815ef0b. Read the comment docs.

@kylecarbs
kylecarbs enabled auto-merge (squash) May 3, 2022 13:59
@kylecarbs
kylecarbs merged commit 60aa40a into main May 3, 2022
@kylecarbs
kylecarbs deleted the peerrace branch May 3, 2022 14:01
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chore: Address race condition in channel.go

3 participants