Repository navigation
feat(examples): add linting to all examples - #12595
Merged
Merged
Conversation
mafredri
force-pushed
the
mafredri/feat-lint-examples
branch
from
March 14, 2024 14:21
d53ceb3 to
03ad9d5
Compare
mafredri
force-pushed
the
mafredri/feat-lint-examples
branch
from
March 14, 2024 14:29
d461d12 to
b981cf2
Compare
mafredri
marked this pull request as ready for review
March 14, 2024 14:34
johnstcn
approved these changes
Mar 14, 2024
| display_name: Incus System Container with Docker | ||
| description: Develop in an Incus System Container with Docker using incus | ||
| icon: /icon/lxc.svg | ||
| icon: ../../../site/static/icon/lxc.svg |
Member
Author
There was a problem hiding this comment.
To be fair, both forms work. But all our other examples/templates use this relative form, and it's handy for confirming that the exact path exists.
Member
There was a problem hiding this comment.
Yep, +1 for enforced consistency!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds linting and validation improved validation for examples templates and matches the requirements imposed by registry.coder.com.
The improvements caught an additional issue:
Ultimately the icon path was correct (as seen from the dashboard), but all other templates use a relative path so that we can verify the icons existence.
Here's another example after fudging up some more files:
Fixes #12588