Skip to content

chore: bump @types/node from 14.18.9 to 14.18.10 - #123

Closed
dependabot[bot] wants to merge 3 commits into
mainfrom
dependabot/npm_and_yarn/types/node-14.18.10
Closed

dependabot[bot] wants to merge 3 commits into
mainfrom
dependabot/npm_and_yarn/types/node-14.18.10

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Feb 1, 2022 •

Copy link
Copy Markdown
Contributor

Bumps @types/node from 14.18.9 to 14.18.10.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 14.18.9 to 14.18.10.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@bryphe-coder bryphe-coder self-assigned this Feb 1, 2022

@bryphe-coder bryphe-coder left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial upgrade; only affects node type definitions - if everything still builds we're OK!

@codecov

codecov Bot commented Feb 1, 2022 •

Copy link
Copy Markdown

Codecov Report

Merging #123 (ff61aa5) into main (38867b0) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
- Coverage   72.09%   72.03%   -0.06%     
==========================================
  Files          91       91              
  Lines        3773     3773              
  Branches       59       59              
==========================================
- Hits         2720     2718       -2     
- Misses        832      835       +3     
+ Partials      221      220       -1     
Flag Coverage Δ
unittest-go-macos-latest 68.07% <ø> (+0.06%) ⬆️
unittest-go-ubuntu-latest 69.93% <ø> (-0.04%) ⬇️
unittest-go-windows-latest ?
unittest-js 74.72% <ø> (ø)
Impacted Files Coverage Δ
peer/channel.go 84.14% <0.00%> (-3.05%) ⬇️
peer/conn.go 78.64% <0.00%> (+0.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38867b0...ff61aa5. Read the comment docs.

@bryphe-coder

Copy link
Copy Markdown
Contributor

@dependabot rebase

@dependabot @github

dependabot Bot commented on behalf of github Feb 1, 2022

Copy link
Copy Markdown
Contributor Author

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@bryphe-coder

Copy link
Copy Markdown
Contributor

@dependabot recreate

@dependabot @github

dependabot Bot commented on behalf of github Feb 1, 2022

Copy link
Copy Markdown
Contributor Author

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@bryphe-coder

Copy link
Copy Markdown
Contributor

@dependabot recreate

@dependabot @github

dependabot Bot commented on behalf of github Feb 1, 2022

Copy link
Copy Markdown
Contributor Author

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@bryphe-coder

Copy link
Copy Markdown
Contributor

Handled in #134

@dependabot @github

dependabot Bot commented on behalf of github Feb 1, 2022

Copy link
Copy Markdown
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot
dependabot Bot deleted the dependabot/npm_and_yarn/types/node-14.18.10 branch February 1, 2022 23:04
ibetitsmike added a commit that referenced this pull request Mar 19, 2026
Previously the mobile PR badge in the agent detail top bar showed the
full PR title, which got truncated and was unreadable on small screens.

Show only the PR number (e.g. #123) colored to match the PR state icon
(green for open, gray for draft, purple for merged, red for closed).
The desktop badge retains its existing icon + title behavior.
kylecarbs added a commit that referenced this pull request May 13, 2026
Adds a `diff_url:` term to the `q` search parameter on `GET
/api/experimental/chats` so callers can look up the chat associated with
a particular pull request, merge request, or any other URL persisted on
the chat's diff status.

```
q=diff_url:"#123"
```

Match is case-insensitive. When the URL lives on a delegated sub-agent's
diff status, the parent chat is returned so the relationship surfaces
from a single lookup.

<details>
<summary>Design notes</summary>

- **Forge-agnostic.** Reuses the existing `chat_diff_statuses.url`
column rather than introducing a `pr:` vocabulary, since the SDK already
documents the URL as "may point to a pull request or a branch page
depending on whether a PR has been opened." Works for GitHub PRs, GitLab
MRs, branch pages, etc.
- **Composes with `archived:`.** The two terms can be combined:
`q=archived:true diff_url:"..."`.
- **Case handling.** The parser used to lowercase the entire `q` string
up front, which would mangle URL path segments. Switched to lowercasing
only the field key inside `searchTerms` (already happens there) and
keeping the value as the caller typed it. The SQL comparison lowercases
on both sides.
- **Validation.** `diff_url` must be a syntactically valid HTTP(S) URL
with a non-empty host. No forge-specific validation.
- **Index.** Adds `idx_chat_diff_statuses_url_lower` on `LOWER(url)` so
the lookup is cheap even on large datasets.
- **Sub-agent fan-in.** `EXISTS` clause matches when the URL lives on
the chat itself or any chat with `root_chat_id` equal to the chat's id,
so a delegated sub-agent's PR pulls in its parent.
- **Deferred.** Sentinels like `pr:any` / `pr:none` and a forge-agnostic
state filter (`diff_state:open|merged|closed`) were intentionally left
out of this change. They couple cleanly to a second forge or a clearer
product call, and shipping them now would lock in vocabulary we may want
to revisit.

</details>

## Tests

- `coderd/searchquery`: parser tests for valid URLs, case handling (key
insensitive, value preserved), composition with `archived:`, and
validation errors (non-HTTP scheme, missing host, malformed URL).
- `coderd/exp_chats_test.go`: end-to-end coverage hitting `ListChats`.
Verifies a root chat matches its own URL, a parent chat surfaces when
only a sub-agent has the URL, lookups are case-insensitive, non-matching
URLs return empty, and invalid URLs return `400`.

---

_This PR was authored by a Coder Agent on behalf of @kylecarbs._
mafredri added a commit that referenced this pull request Sep 22, 2026
Before the list resolved the board rendered as an empty board with
"0 chats · 0 cards", and an active search with no result yet, or a
failed one, admitted every card, so a broken search looked like an
unfiltered board. Loading and failure now render as such; prior search
results stay while the next search loads, and a failed background
refetch keeps the board (and any open note editor) mounted with the
failure shown inline.

Board storage is keyed by user id so accounts sharing a browser do not
inherit each other's columns and pinned windows. The old anonymous key
is not migrated; that state is browser-local by design.

Also from the second review round: the PR chip's accessible name keeps
its visible "#123", a comment claiming the list API caps pages at 200
is gone (only the messages endpoint does), narrating comments are cut
to the constraint they explain, a partial DOMRect fixture is a real
rectangle, a presence-only Inbox test is dropped in favour of the
command-level coverage, and one single-use span wrapper is inlined.
mafredri added a commit that referenced this pull request Sep 28, 2026
Before the list resolved the board rendered as an empty board with
"0 chats · 0 cards", and an active search with no result yet, or a
failed one, admitted every card, so a broken search looked like an
unfiltered board. Loading and failure now render as such; prior search
results stay while the next search loads, and a failed background
refetch keeps the board (and any open note editor) mounted with the
failure shown inline.

Board storage is keyed by user id so accounts sharing a browser do not
inherit each other's columns and pinned windows. The old anonymous key
is not migrated; that state is browser-local by design.

Also from the second review round: the PR chip's accessible name keeps
its visible "#123", a comment claiming the list API caps pages at 200
is gone (only the messages endpoint does), narrating comments are cut
to the constraint they explain, a partial DOMRect fixture is a real
rectangle, a presence-only Inbox test is dropped in favour of the
command-level coverage, and one single-use span wrapper is inlined.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant