feat: Create provisioner abstraction#12
Merged
Merged
Conversation
Creates a provisioner abstraction that takes prior art from the Terraform plugin system. It's safe to assume this code will change a lot when it becomes integrated with provisionerd. Closes #10.
Codecov Report
@@ Coverage Diff @@
## main #12 +/- ##
==========================================
- Coverage 69.93% 69.48% -0.45%
==========================================
Files 10 15 +5
Lines 735 888 +153
==========================================
+ Hits 514 617 +103
- Misses 177 212 +35
- Partials 44 59 +15
Continue to review full report at Codecov.
|
bryphe-coder
reviewed
Jan 7, 2022
bryphe-coder
reviewed
Jan 7, 2022
bryphe-coder
reviewed
Jan 7, 2022
bryphe-coder
reviewed
Jan 7, 2022
bryphe-coder
approved these changes
Jan 7, 2022
bryphe-coder
reviewed
Jan 7, 2022
bryphe-coder
reviewed
Jan 7, 2022
ketang
reviewed
Jan 9, 2022
| ) | ||
|
|
||
| // Provision executes `terraform apply`. | ||
| func (t *terraform) Provision(ctx context.Context, request *proto.Provision_Request) (*proto.Provision_Response, error) { |
Contributor
There was a problem hiding this comment.
@kylecarbs should we name this according to the canonical action names instead of Provision?
Member
Author
There was a problem hiding this comment.
Hmm. So WorkspaceProvision instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates a provisioner abstraction that takes prior art from the Terraform plugin system. It's safe to assume this code will change a lot when it becomes integrated with provisionerd.
Closes #10.