Skip to content

feat: use Agent v2 API for Service Banner - #11806

Merged
spikecurtis merged 1 commit into
mainfrom
spike/10534-service-banner
Jan 30, 2024
Merged

spikecurtis merged 1 commit into
mainfrom
spike/10534-service-banner

Conversation

@spikecurtis

@spikecurtis spikecurtis commented Jan 24, 2024 •

Copy link
Copy Markdown
Collaborator

Agent uses the v2 API for the service banner, rather than the v1 HTTP API.

One of several for #10534

@spikecurtis
spikecurtis marked this pull request as ready for review January 24, 2024 18:15
@spikecurtis
spikecurtis force-pushed the spike/10534-agentapi-appearance-fetcher branch from cfe6dcc to 6f243f6 Compare January 25, 2024 11:24
@spikecurtis
spikecurtis force-pushed the spike/10534-service-banner branch from 368f754 to 4dc08bc Compare January 25, 2024 11:24
@spikecurtis
spikecurtis force-pushed the spike/10534-service-banner branch from 4dc08bc to 6e7e25f Compare January 25, 2024 12:30
@spikecurtis
spikecurtis force-pushed the spike/10534-agentapi-appearance-fetcher branch from 6f243f6 to a85394d Compare January 26, 2024 06:47
@spikecurtis
spikecurtis force-pushed the spike/10534-service-banner branch from 6e7e25f to c4af306 Compare January 26, 2024 06:47
@spikecurtis
spikecurtis force-pushed the spike/10534-agentapi-appearance-fetcher branch from a85394d to 1c21905 Compare January 26, 2024 09:24
@spikecurtis
spikecurtis force-pushed the spike/10534-service-banner branch from c4af306 to 4579eae Compare January 26, 2024 09:24
@spikecurtis
spikecurtis force-pushed the spike/10534-agentapi-appearance-fetcher branch from 1c21905 to 98ab55e Compare January 26, 2024 15:27
@spikecurtis
spikecurtis force-pushed the spike/10534-service-banner branch from 4579eae to 7961d48 Compare January 26, 2024 15:28
@spikecurtis
spikecurtis force-pushed the spike/10534-agentapi-appearance-fetcher branch from 98ab55e to 174664c Compare January 29, 2024 07:57
@spikecurtis
spikecurtis force-pushed the spike/10534-service-banner branch from 7961d48 to 04cdbc1 Compare January 29, 2024 07:57
@spikecurtis
spikecurtis force-pushed the spike/10534-agentapi-appearance-fetcher branch from 174664c to 385e74a Compare January 29, 2024 10:44
@spikecurtis
spikecurtis force-pushed the spike/10534-service-banner branch from 04cdbc1 to 320f232 Compare January 29, 2024 10:44
@spikecurtis
spikecurtis force-pushed the spike/10534-agentapi-appearance-fetcher branch from 385e74a to 43a1c9e Compare January 29, 2024 12:31
@spikecurtis
spikecurtis force-pushed the spike/10534-service-banner branch from 320f232 to 492a7d4 Compare January 29, 2024 12:31
Comment thread agent/agenttest/client.go Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you generate this?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could generate it as a Mock, but that won't fit as easily into our existing tests.

Base automatically changed from spike/10534-agentapi-appearance-fetcher to main January 29, 2024 17:22
@spikecurtis
spikecurtis force-pushed the spike/10534-service-banner branch from 492a7d4 to a401924 Compare January 30, 2024 03:36
@spikecurtis
spikecurtis merged commit 13e24f2 into main Jan 30, 2024
@spikecurtis
spikecurtis deleted the spike/10534-service-banner branch January 30, 2024 03:44

Copy link
Copy Markdown
Collaborator Author

Merge activity

@github-actions github-actions Bot locked and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants