Skip to content

chore: refactor Appearance to an interface callable by AGPL code - #11769

Merged
spikecurtis merged 1 commit into
mainfrom
spike/10534-appearance-refactor
Jan 29, 2024
Merged

spikecurtis merged 1 commit into
mainfrom
spike/10534-appearance-refactor

Conversation

@spikecurtis

@spikecurtis spikecurtis commented Jan 23, 2024 •

Copy link
Copy Markdown
Collaborator

The new Agent API needs an interface for ServiceBanners, so this PR creates it and refactors the AGPL and Enterprise code to achieve it.

Before we depended on the fact that the HTTP endpoint was missing to serve an empty ServiceBanner on AGPL deployments, but that won't work with dRPC, so we need a real interface to call.

@spikecurtis
spikecurtis marked this pull request as ready for review January 23, 2024 10:24
@spikecurtis
spikecurtis force-pushed the spike/10534-service-banners-test branch from 5c875b2 to f168e58 Compare January 23, 2024 18:25
@spikecurtis
spikecurtis force-pushed the spike/10534-appearance-refactor branch from d63b387 to 5ad6f3f Compare January 23, 2024 18:25

@code-asher code-asher left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! You probably already saw the tests but in case not I suppose in some tests we are not setting AppearanceFetcher on the site handler or something like that.

@spikecurtis
spikecurtis force-pushed the spike/10534-service-banners-test branch from e980510 to eaabdb7 Compare January 25, 2024 11:24
@spikecurtis
spikecurtis force-pushed the spike/10534-appearance-refactor branch from cdec5e1 to 79bee1c Compare January 25, 2024 11:24
@spikecurtis
spikecurtis force-pushed the spike/10534-service-banners-test branch from eaabdb7 to 6a70ddf Compare January 26, 2024 06:47
@spikecurtis
spikecurtis force-pushed the spike/10534-appearance-refactor branch from 79bee1c to 529250f Compare January 26, 2024 06:47
@spikecurtis
spikecurtis force-pushed the spike/10534-service-banners-test branch from 6a70ddf to c980d65 Compare January 26, 2024 09:24
@spikecurtis
spikecurtis force-pushed the spike/10534-appearance-refactor branch from 529250f to 25063cb Compare January 26, 2024 09:24
@spikecurtis
spikecurtis force-pushed the spike/10534-service-banners-test branch from c980d65 to 38f23ea Compare January 26, 2024 15:27
@spikecurtis
spikecurtis force-pushed the spike/10534-appearance-refactor branch from 25063cb to 06d2b3d Compare January 26, 2024 15:27
Base automatically changed from spike/10534-service-banners-test to main January 29, 2024 07:56
@spikecurtis
spikecurtis force-pushed the spike/10534-appearance-refactor branch from 06d2b3d to 810bb6e Compare January 29, 2024 07:57
@spikecurtis
spikecurtis merged commit bc4ae53 into main Jan 29, 2024

Copy link
Copy Markdown
Collaborator Author

Merge activity

@spikecurtis
spikecurtis deleted the spike/10534-appearance-refactor branch January 29, 2024 08:17
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants