Repository navigation
fix: fix TestServiceBanners/Agent - #11768
Merged
Merged
Conversation
This was referenced Jan 23, 2024
This was referenced Jan 23, 2024
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @spikecurtis and the rest of your teammates on |
This was referenced Jan 23, 2024
spikecurtis
marked this pull request as ready for review
January 23, 2024 10:22
code-asher
approved these changes
Jan 23, 2024
code-asher
left a comment
Member
There was a problem hiding this comment.
Ahhh that makes sense, I really misunderstood the client setup. Thank you for fixing!
spikecurtis
force-pushed
the
spike/10533-codersdk-derp-map
branch
from
January 23, 2024 18:25
ffbd488 to
05b6c81
Compare
spikecurtis
force-pushed
the
spike/10534-service-banners-test
branch
from
January 23, 2024 18:25
5c875b2 to
f168e58
Compare
spikecurtis
force-pushed
the
spike/10533-codersdk-derp-map
branch
from
January 24, 2024 10:26
05b6c81 to
7218a92
Compare
spikecurtis
force-pushed
the
spike/10534-service-banners-test
branch
from
January 24, 2024 10:26
f168e58 to
faa1f29
Compare
spikecurtis
force-pushed
the
spike/10533-codersdk-derp-map
branch
from
January 24, 2024 12:55
7218a92 to
7297387
Compare
spikecurtis
force-pushed
the
spike/10534-service-banners-test
branch
from
January 24, 2024 12:56
faa1f29 to
e980510
Compare
spikecurtis
force-pushed
the
spike/10533-codersdk-derp-map
branch
from
January 25, 2024 11:23
7297387 to
280a501
Compare
spikecurtis
force-pushed
the
spike/10534-service-banners-test
branch
from
January 25, 2024 11:24
e980510 to
eaabdb7
Compare
spikecurtis
force-pushed
the
spike/10533-codersdk-derp-map
branch
from
January 26, 2024 06:47
280a501 to
bfbb557
Compare
spikecurtis
force-pushed
the
spike/10534-service-banners-test
branch
from
January 26, 2024 06:47
eaabdb7 to
6a70ddf
Compare
spikecurtis
force-pushed
the
spike/10533-codersdk-derp-map
branch
from
January 26, 2024 09:24
bfbb557 to
5abcdd4
Compare
spikecurtis
force-pushed
the
spike/10534-service-banners-test
branch
from
January 26, 2024 09:24
6a70ddf to
c980d65
Compare
This was referenced Jan 26, 2024
spikecurtis
force-pushed
the
spike/10533-codersdk-derp-map
branch
from
January 26, 2024 15:27
5abcdd4 to
0a384f2
Compare
spikecurtis
force-pushed
the
spike/10534-service-banners-test
branch
from
January 26, 2024 15:27
c980d65 to
38f23ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The original test is bugged in that it