Repository navigation
feat: check agent API version on connection - #11696
Merged
Merged
Conversation
This was referenced Jan 19, 2024
This was referenced Jan 19, 2024
Collaborator
Author
This was referenced Jan 19, 2024
spikecurtis
marked this pull request as ready for review
January 19, 2024 08:24
spikecurtis
force-pushed
the
spike/10533-servertailnet-set-lost
branch
from
January 19, 2024 12:36
c7f73d4 to
135bd48
Compare
spikecurtis
force-pushed
the
spike/10531-check-agent-api-version
branch
from
January 19, 2024 12:36
3469608 to
f56be8e
Compare
spikecurtis
force-pushed
the
spike/10533-servertailnet-set-lost
branch
from
January 22, 2024 06:58
135bd48 to
ecef2a9
Compare
spikecurtis
force-pushed
the
spike/10531-check-agent-api-version
branch
from
January 22, 2024 06:59
f56be8e to
24a943c
Compare
spikecurtis
force-pushed
the
spike/10533-servertailnet-set-lost
branch
from
January 22, 2024 08:05
ecef2a9 to
0b0b1a4
Compare
spikecurtis
force-pushed
the
spike/10531-check-agent-api-version
branch
from
January 22, 2024 08:05
24a943c to
16322d1
Compare
deansheather
approved these changes
Jan 22, 2024
spikecurtis
force-pushed
the
spike/10533-servertailnet-set-lost
branch
from
January 22, 2024 11:18
0b0b1a4 to
7a301f1
Compare
spikecurtis
force-pushed
the
spike/10531-check-agent-api-version
branch
from
January 22, 2024 11:18
16322d1 to
c91b1c0
Compare
spikecurtis
force-pushed
the
spike/10533-servertailnet-set-lost
branch
from
January 22, 2024 11:30
7a301f1 to
0e38400
Compare
spikecurtis
force-pushed
the
spike/10531-check-agent-api-version
branch
from
January 22, 2024 11:30
c91b1c0 to
671a2e9
Compare
spikecurtis
force-pushed
the
spike/10533-servertailnet-set-lost
branch
from
January 22, 2024 12:47
0e38400 to
35d99a8
Compare
spikecurtis
force-pushed
the
spike/10531-check-agent-api-version
branch
from
January 22, 2024 12:47
671a2e9 to
5fa6879
Compare
spikecurtis
force-pushed
the
spike/10533-servertailnet-set-lost
branch
from
January 22, 2024 12:48
35d99a8 to
66da7c6
Compare
spikecurtis
force-pushed
the
spike/10531-check-agent-api-version
branch
from
January 22, 2024 12:48
5fa6879 to
8ad2024
Compare
spikecurtis
force-pushed
the
spike/10533-servertailnet-set-lost
branch
from
January 23, 2024 05:52
66da7c6 to
62e95de
Compare
spikecurtis
force-pushed
the
spike/10531-check-agent-api-version
branch
from
January 23, 2024 05:52
8ad2024 to
d7a1794
Compare
spikecurtis
force-pushed
the
spike/10533-servertailnet-set-lost
branch
from
January 23, 2024 09:09
62e95de to
5695841
Compare
spikecurtis
force-pushed
the
spike/10531-check-agent-api-version
branch
from
January 23, 2024 09:09
d7a1794 to
59e8c2f
Compare
spikecurtis
force-pushed
the
spike/10531-check-agent-api-version
branch
from
January 23, 2024 10:19
59e8c2f to
8cbda21
Compare
This was referenced Jan 23, 2024
Collaborator
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

fixes #10531
Adds a check for
versionon connection to the Agent API websocket endpoint. This is primarily for future-proofing, so that up-level agents get a sensible error if they connect to a back-level Coderd.It also refactors the location of the
CurrentVersionvariables, to be part of theprotopackages, since the versions refer to the APIs defined therein.