Repository navigation
feat: set peers lost when disconnected from coordinator - #11681
Merged
Merged
Conversation
This was referenced Jan 18, 2024
This was referenced Jan 18, 2024
Collaborator
Author
spikecurtis
marked this pull request as ready for review
January 18, 2024 10:05
spikecurtis
force-pushed
the
spike/10533-setAllPeersLost
branch
from
January 19, 2024 06:59
1a2dccd to
48d4734
Compare
spikecurtis
force-pushed
the
spike/10533-set-lost-disconnect
branch
from
January 19, 2024 06:59
caedbc8 to
951f803
Compare
spikecurtis
force-pushed
the
spike/10533-setAllPeersLost
branch
from
January 19, 2024 08:20
48d4734 to
58f3848
Compare
spikecurtis
force-pushed
the
spike/10533-set-lost-disconnect
branch
from
January 19, 2024 08:20
951f803 to
771cdf1
Compare
spikecurtis
force-pushed
the
spike/10533-setAllPeersLost
branch
from
January 19, 2024 12:36
58f3848 to
2daadfc
Compare
spikecurtis
force-pushed
the
spike/10533-set-lost-disconnect
branch
from
January 19, 2024 12:36
771cdf1 to
2d92458
Compare
coadler
approved these changes
Jan 22, 2024
spikecurtis
force-pushed
the
spike/10533-setAllPeersLost
branch
from
January 22, 2024 06:58
2daadfc to
277215a
Compare
spikecurtis
force-pushed
the
spike/10533-set-lost-disconnect
branch
from
January 22, 2024 06:58
2d92458 to
9c1f310
Compare
spikecurtis
force-pushed
the
spike/10533-setAllPeersLost
branch
from
January 22, 2024 08:05
277215a to
d476a87
Compare
spikecurtis
force-pushed
the
spike/10533-set-lost-disconnect
branch
from
January 22, 2024 08:05
9c1f310 to
53b97df
Compare
spikecurtis
force-pushed
the
spike/10533-set-lost-disconnect
branch
from
January 22, 2024 11:18
53b97df to
9cf8f03
Compare
Collaborator
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adds support to Coordination to call SetAllPeersLost() when it is closed. This ensure that when we disconnect from a Coordinator, we set all peers lost.
This covers CoderSDK (CLI client) and Agent. Next PR will cover MultiAgent (notably,
wsproxy).