Skip to content

chore: stop passing addresses on configMaps constructor - #11634

Merged
spikecurtis merged 1 commit into
mainfrom
spike/10533-addresses-constructor
Jan 18, 2024
Merged

spikecurtis merged 1 commit into
mainfrom
spike/10533-addresses-constructor

Conversation

@spikecurtis

@spikecurtis spikecurtis commented Jan 16, 2024 •

Copy link
Copy Markdown
Collaborator

moving this out of the constructor so that setting this when creating a new tailnet.Conn triggers configuring the engine.

spikecurtis commented Jan 16, 2024 •

Copy link
Copy Markdown
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spikecurtis and the rest of your teammates on Graphite Graphite

@spikecurtis
spikecurtis force-pushed the spike/10533-setDERPMap branch from 5e1a15b to 48db7e0 Compare January 17, 2024 05:41
@spikecurtis
spikecurtis force-pushed the spike/10533-addresses-constructor branch from cf32bef to df12694 Compare January 17, 2024 05:41
@spikecurtis
spikecurtis force-pushed the spike/10533-setDERPMap branch from 48db7e0 to 1ebd378 Compare January 17, 2024 10:03
@spikecurtis
spikecurtis force-pushed the spike/10533-addresses-constructor branch from df12694 to 5ed9e70 Compare January 17, 2024 10:03
@spikecurtis
spikecurtis force-pushed the spike/10533-setDERPMap branch from 1ebd378 to a063062 Compare January 17, 2024 11:49
@spikecurtis
spikecurtis force-pushed the spike/10533-addresses-constructor branch from 5ed9e70 to 3d1daef Compare January 17, 2024 11:49
@spikecurtis
spikecurtis force-pushed the spike/10533-setDERPMap branch from a063062 to bbbdf4d Compare January 18, 2024 05:24
Base automatically changed from spike/10533-setDERPMap to main January 18, 2024 05:34
@spikecurtis
spikecurtis force-pushed the spike/10533-addresses-constructor branch from 3d1daef to c6faac9 Compare January 18, 2024 05:34

spikecurtis commented Jan 18, 2024 •

Copy link
Copy Markdown
Collaborator Author

Merge activity

  • Jan 18, 12:35 AM: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
  • Jan 18, 12:43 AM: @spikecurtis merged this pull request with Graphite.

@spikecurtis
spikecurtis merged commit e725f9d into main Jan 18, 2024
@spikecurtis
spikecurtis deleted the spike/10533-addresses-constructor branch January 18, 2024 05:43
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants