Repository navigation
chore: stop passing addresses on configMaps constructor - #11634
Merged
Merged
Conversation
This was referenced Jan 16, 2024
This was referenced Jan 16, 2024
Collaborator
Author
This was referenced Jan 16, 2024
spikecurtis
marked this pull request as ready for review
January 16, 2024 12:28
spikecurtis
force-pushed
the
spike/10533-setDERPMap
branch
from
January 17, 2024 04:56
0084573 to
5e1a15b
Compare
spikecurtis
force-pushed
the
spike/10533-addresses-constructor
branch
from
January 17, 2024 04:56
50b2855 to
cf32bef
Compare
coadler
approved these changes
Jan 17, 2024
spikecurtis
force-pushed
the
spike/10533-setDERPMap
branch
from
January 17, 2024 05:41
5e1a15b to
48db7e0
Compare
spikecurtis
force-pushed
the
spike/10533-addresses-constructor
branch
from
January 17, 2024 05:41
cf32bef to
df12694
Compare
spikecurtis
force-pushed
the
spike/10533-setDERPMap
branch
from
January 17, 2024 10:03
48db7e0 to
1ebd378
Compare
spikecurtis
force-pushed
the
spike/10533-addresses-constructor
branch
from
January 17, 2024 10:03
df12694 to
5ed9e70
Compare
spikecurtis
force-pushed
the
spike/10533-setDERPMap
branch
from
January 17, 2024 11:49
1ebd378 to
a063062
Compare
spikecurtis
force-pushed
the
spike/10533-addresses-constructor
branch
from
January 17, 2024 11:49
5ed9e70 to
3d1daef
Compare
spikecurtis
force-pushed
the
spike/10533-setDERPMap
branch
from
January 18, 2024 05:24
a063062 to
bbbdf4d
Compare
spikecurtis
force-pushed
the
spike/10533-addresses-constructor
branch
from
January 18, 2024 05:34
3d1daef to
c6faac9
Compare
Collaborator
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

moving this out of the constructor so that setting this when creating a new
tailnet.Conntriggers configuring the engine.