Skip to content

fix: correct perms for forbidden error in TemplateScheduleStore.Load - #11286

Merged
Emyrk merged 4 commits into
mainfrom
stevenmasley/template_sch_load
Dec 20, 2023
Merged

Emyrk merged 4 commits into
mainfrom
stevenmasley/template_sch_load

Conversation

@Emyrk

@Emyrk Emyrk commented Dec 19, 2023

Copy link
Copy Markdown
Member

Unit test

Elevating the log level to error makes the unit test fail. This should be a failure, this should never happen.

@Emyrk
Emyrk requested a review from johnstcn December 19, 2023 21:37
Comment on lines -264 to +267
workspace_builds.build_number
workspace_builds.build_number,
workspace_builds.template_version_id

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is totally safe

@johnstcn johnstcn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This looks fine to me once CI is happy.

@Emyrk Emyrk changed the title chore: TemplateScheduleStore.Load() throwing forbidden error chore: func TemplateScheduleStore.Load() throwing forbidden error Dec 20, 2023
@Emyrk Emyrk changed the title chore: func TemplateScheduleStore.Load() throwing forbidden error fix: correct perms for forbidden error in TemplateScheduleStore.Load Dec 20, 2023
@Emyrk
Emyrk merged commit fe867d0 into main Dec 20, 2023
@Emyrk
Emyrk deleted the stevenmasley/template_sch_load branch December 20, 2023 17:38
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants