Skip to content

refactor(coderd/healthcheck): make Warnings an object with { Code, Message } - #10950

Merged
johnstcn merged 6 commits into
mainfrom
cj/healthcheck-warnings-refactor
Nov 30, 2023
Merged

johnstcn merged 6 commits into
mainfrom
cj/healthcheck-warnings-refactor

Conversation

@johnstcn

@johnstcn johnstcn commented Nov 30, 2023 •

Copy link
Copy Markdown
Member

Relates to #8965

Follow-up of #10915

This is so the UI doesn't need to do any nasty regex extraction from error messages to get the code.

@johnstcn johnstcn self-assigned this Nov 30, 2023

@mtojek mtojek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactoring looks good to me, and I like the convenience functions 👍

@johnstcn
johnstcn merged commit 0789500 into main Nov 30, 2023
@johnstcn
johnstcn deleted the cj/healthcheck-warnings-refactor branch November 30, 2023 14:49
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants