Skip to content

feat: include health severity in reports - #10817

Merged
mtojek merged 21 commits into
mainfrom
9754-severity
Nov 23, 2023
Merged

mtojek merged 21 commits into
mainfrom
9754-severity

Conversation

@mtojek

@mtojek mtojek commented Nov 21, 2023 •

Copy link
Copy Markdown
Member

Fixes: #9754

This PR adds severity enum (ok, warning, error) to health reports, and modifies rules based on which severity level is selected.

Rules:

  • AccessURL: Warning if the endpoint is responding but it isn't HTTP 200
  • Database: Warning if the latency threshold is breached, but database is responding
  • DERP: Warning if one node in the region is unhealthy
  • DERP: Use highest severity for the region if more than 1 node is unhealthy
  • DERP: Warning if users must use WebSockets

@mtojek mtojek self-assigned this Nov 21, 2023
@mtojek
mtojek requested a review from johnstcn November 22, 2023 19:04
@mtojek
mtojek marked this pull request as ready for review November 22, 2023 19:04
Comment thread coderd/healthcheck/derphealth/derp.go Resolved
Comment thread coderd/healthcheck/accessurl.go Resolved
Comment thread coderd/healthcheck/derphealth/doc.go Resolved
Comment thread coderd/healthcheck/health/model.go Resolved
Comment thread coderd/healthcheck/derphealth/derp.go Resolved

@johnstcn johnstcn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one nit about potential nil, otherwise LGTM

@mtojek
mtojek merged commit 78df683 into main Nov 23, 2023
@mtojek
mtojek deleted the 9754-severity branch November 23, 2023 15:08
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

health check: severity levels

2 participants