Repository navigation
feat: ensure coder remains healthy with single degraded DERP server - #10813
Merged
Merged
Conversation
mtojek
marked this pull request as ready for review
November 21, 2023 11:19
johnstcn
approved these changes
Nov 21, 2023
johnstcn
left a comment
Member
There was a problem hiding this comment.
Potentially out of scope of this PR, but do we need to handle the case where there are no nodes?
Co-authored-by: Cian Johnston <cian@coder.com>
Member
Author
I checked it now. Tailscale does not like regions without nodes and it panics. I suppose that we're good then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8966
This PR modifies DERP healthcheck logic to consider a region with a single degraded DERP to be healthy. I will add severity levels in #9754.