Skip to content

fix: fail server startup on invalid DERP map - #10536

Merged
deansheather merged 1 commit into
mainfrom
dean/fail-on-invalid-derp-map
Nov 6, 2023
Merged

deansheather merged 1 commit into
mainfrom
dean/fail-on-invalid-derp-map

Conversation

@deansheather

Copy link
Copy Markdown
Collaborator

Prevents users from trying to start with an invalid configuration and being unable to connect to any workspaces due to an empty DERP map. If you disable the built-in server and don't specify a custom DERP map, workspaces are completely inaccessible once started.

Closes #7173

@johnstcn johnstcn left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

But this should be fix and not chore.

@deansheather deansheather changed the title chore: fail server startup on invalid DERP map fix: fail server startup on invalid DERP map Nov 6, 2023
@deansheather
deansheather merged commit 95e5419 into main Nov 6, 2023
@deansheather
deansheather deleted the dean/fail-on-invalid-derp-map branch November 6, 2023 13:04
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Coder server should fail (or health check) if the internal derp server is disabled and there are no custom derps

2 participants