Skip to content

ci: Don't run internal steps if forked - #1045

Closed
kylecarbs wants to merge 1 commit into
mainfrom
rmexternalvars
Closed

kylecarbs wants to merge 1 commit into
mainfrom
rmexternalvars

Conversation

@kylecarbs

Copy link
Copy Markdown
Member

This was causing CI to fail for contributions.

@kylecarbs
kylecarbs requested a review from coadler April 15, 2022 20:29
@kylecarbs kylecarbs self-assigned this Apr 15, 2022
Comment thread .github/workflows/coder.yaml Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to check if the secret is empty?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently you can't... actions/runner#520

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, you can. It's just janky.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unlucky

@codecov

codecov Bot commented Apr 15, 2022 •

Copy link
Copy Markdown

Codecov Report

Merging #1045 (5065c4e) into main (a13ccee) will decrease coverage by 11.22%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #1045       +/-   ##
===========================================
- Coverage   67.48%   56.26%   -11.23%     
===========================================
  Files         259      133      -126     
  Lines       15059    13464     -1595     
  Branches      151        0      -151     
===========================================
- Hits        10162     7575     -2587     
- Misses       3881     5006     +1125     
+ Partials     1016      883      -133     
Flag Coverage Δ
unittest-go-macos-latest ?
unittest-go-postgres- ?
unittest-go-ubuntu-latest 56.26% <ø> (+0.08%) ⬆️
unittest-go-windows-2022 ?
unittest-js ?
Impacted Files Coverage Δ
coderd/database/queries.sql.go 0.00% <0.00%> (-83.87%) ⬇️
coderd/devtunnel/tunnel.go 0.00% <0.00%> (-79.67%) ⬇️
coderd/database/pubsub.go 0.00% <0.00%> (-77.78%) ⬇️
coderd/database/db.go 0.00% <0.00%> (-55.18%) ⬇️
coderd/database/migrate.go 0.00% <0.00%> (-45.00%) ⬇️
cli/config/file.go 69.44% <0.00%> (-8.34%) ⬇️
provisionersdk/serve.go 35.13% <0.00%> (-8.11%) ⬇️
cli/configssh.go 61.41% <0.00%> (-7.09%) ⬇️
provisionersdk/transport.go 78.72% <0.00%> (-6.39%) ⬇️
coderd/coderdtest/coderdtest.go 93.24% <0.00%> (-6.09%) ⬇️
... and 138 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a13ccee...5065c4e. Read the comment docs.

Comment thread .github/workflows/coder.yaml Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also random thought, (success() || failure()) can just be always()

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Will change

This was causing CI to fail for contributions.
@kylecarbs kylecarbs closed this Apr 16, 2022
@kylecarbs
kylecarbs deleted the rmexternalvars branch April 16, 2022 17:18
@coadler

coadler commented Apr 16, 2022

Copy link
Copy Markdown
Contributor

Did you mean to merge this?

@kylecarbs

Copy link
Copy Markdown
Member Author

Nah nah I opened this as a fork instead just to confirm it works

@kylecarbs

Copy link
Copy Markdown
Member Author

#1048

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants