Skip to content

feat: add GET /api/v2/users - #1028

Merged
BrunoQuaresma merged 3 commits into
mainfrom
bq/users-endpoint
Apr 18, 2022
Merged

BrunoQuaresma merged 3 commits into
mainfrom
bq/users-endpoint

Conversation

@BrunoQuaresma

Copy link
Copy Markdown
Contributor

Related to #598 and #198

@BrunoQuaresma BrunoQuaresma self-assigned this Apr 15, 2022
@BrunoQuaresma
BrunoQuaresma removed the request for review from coadler April 15, 2022 15:51
@codecov

codecov Bot commented Apr 15, 2022 •

Copy link
Copy Markdown

Codecov Report

Merging #1028 (e90c285) into main (721cb88) will increase coverage by 0.85%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##             main    #1028      +/-   ##
==========================================
+ Coverage   66.98%   67.84%   +0.85%     
==========================================
  Files         256      259       +3     
  Lines       14987    15225     +238     
  Branches      136      154      +18     
==========================================
+ Hits        10039    10329     +290     
+ Misses       3952     3881      -71     
- Partials      996     1015      +19     
Flag Coverage Δ
unittest-go-macos-latest 53.87% <25.00%> (+0.41%) ⬆️
unittest-go-postgres- 67.09% <57.14%> (+0.24%) ⬆️
unittest-go-ubuntu-latest 56.46% <25.00%> (+0.24%) ⬆️
unittest-go-windows-2022 52.97% <25.00%> (-0.07%) ⬇️
unittest-js 68.58% <ø> (+5.61%) ⬆️
Impacted Files Coverage Δ
codersdk/users.go 64.60% <45.45%> (-1.27%) ⬇️
coderd/users.go 59.56% <57.14%> (-0.05%) ⬇️
coderd/database/queries.sql.go 83.37% <60.00%> (-0.49%) ⬇️
coderd/coderd.go 97.23% <100.00%> (+0.01%) ⬆️
codersdk/provisionerdaemons.go 59.70% <0.00%> (-5.98%) ⬇️
coderd/workspaceagents.go 59.82% <0.00%> (-5.36%) ⬇️
site/src/test_helpers/index.tsx 95.45% <0.00%> (-4.55%) ⬇️
site/src/components/Form/index.ts 95.83% <0.00%> (-4.17%) ⬇️
site/src/xServices/auth/authXService.ts 79.31% <0.00%> (-2.51%) ⬇️
provisioner/echo/serve.go 56.80% <0.00%> (-2.41%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 721cb88...e90c285. Read the comment docs.

@BrunoQuaresma

Copy link
Copy Markdown
Contributor Author

Looks like the lint and style errors are related to version stuff 🤔 when things get approved I will fix them.

Comment thread coderd/coderd.go Resolved
@BrunoQuaresma
BrunoQuaresma requested a review from kylecarbs April 15, 2022 15:59
@BrunoQuaresma
BrunoQuaresma enabled auto-merge (squash) April 18, 2022 17:08
@BrunoQuaresma
BrunoQuaresma merged commit 1df750b into main Apr 18, 2022
@BrunoQuaresma
BrunoQuaresma deleted the bq/users-endpoint branch April 18, 2022 17:19
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants